[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 08/10] block/nbd: rename NBDConnectThread to NBDClientConn
From: |
Roman Kagan |
Subject: |
Re: [PATCH v2 08/10] block/nbd: rename NBDConnectThread to NBDClientConnection |
Date: |
Thu, 8 Apr 2021 19:54:16 +0300 |
On Thu, Apr 08, 2021 at 05:08:25PM +0300, Vladimir Sementsov-Ogievskiy wrote:
> We are going to move connection code to own file and want clear names
> and APIs.
>
> The structure is shared between user and (possibly) several runs of
> connect-thread. So it's wrong to call it "thread". Let's rename to
> something more generic.
>
> Appropriately rename connect_thread and thr variables to conn.
>
> connect_thread_state_unref() function gets new appropriate name too
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> ---
> block/nbd.c | 127 ++++++++++++++++++++++++++--------------------------
> 1 file changed, 63 insertions(+), 64 deletions(-)
[To other reviewers: in addition to renaming there's one blank line
removed, hence the difference between (+) and (-)]
Reviewed-by: Roman Kagan <rvkagan@yandex-team.ru>
- [PATCH v2 00/10] block/nbd: move connection code to separate file, Vladimir Sementsov-Ogievskiy, 2021/04/08
- [PATCH v2 04/10] block/nbd: simplify waking of nbd_co_establish_connection(), Vladimir Sementsov-Ogievskiy, 2021/04/08
- [PATCH v2 01/10] block/nbd: introduce NBDConnectThread reference counter, Vladimir Sementsov-Ogievskiy, 2021/04/08
- [PATCH v2 08/10] block/nbd: rename NBDConnectThread to NBDClientConnection, Vladimir Sementsov-Ogievskiy, 2021/04/08
- Re: [PATCH v2 08/10] block/nbd: rename NBDConnectThread to NBDClientConnection,
Roman Kagan <=
- [PATCH v2 05/10] block/nbd: drop thr->state, Vladimir Sementsov-Ogievskiy, 2021/04/08
- [PATCH v2 02/10] block/nbd: BDRVNBDState: drop unused connect_err and connect_status, Vladimir Sementsov-Ogievskiy, 2021/04/08
- [PATCH v2 07/10] block/nbd: make nbd_co_establish_connection_cancel() bs-independent, Vladimir Sementsov-Ogievskiy, 2021/04/08
- [PATCH v2 09/10] block/nbd: introduce nbd_client_connection_new(), Vladimir Sementsov-Ogievskiy, 2021/04/08
- [PATCH v2 10/10] nbd: move connection code from block/nbd to nbd/client-connection, Vladimir Sementsov-Ogievskiy, 2021/04/08