[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 1/4] mirror: Move open_backing_file to exit_common
From: |
Max Reitz |
Subject: |
[PATCH 1/4] mirror: Move open_backing_file to exit_common |
Date: |
Fri, 9 Apr 2021 14:04:18 +0200 |
This is a graph change and therefore should be done in job-finalize
(which is what invokes mirror_exit_common()).
Signed-off-by: Max Reitz <mreitz@redhat.com>
---
block/mirror.c | 22 ++++++++--------------
1 file changed, 8 insertions(+), 14 deletions(-)
diff --git a/block/mirror.c b/block/mirror.c
index d7e54c0ff7..f1f936bf1a 100644
--- a/block/mirror.c
+++ b/block/mirror.c
@@ -689,6 +689,14 @@ static int mirror_exit_common(Job *job)
ret = -EPERM;
}
}
+ } else if (!abort && s->backing_mode == MIRROR_OPEN_BACKING_CHAIN) {
+ assert(!bdrv_backing_chain_next(target_bs));
+ ret = bdrv_open_backing_file(bdrv_skip_filters(target_bs), NULL,
+ "backing", &local_err);
+ if (ret < 0) {
+ error_report_err(local_err);
+ local_err = NULL;
+ }
}
if (s->to_replace) {
@@ -1107,9 +1115,6 @@ immediate_exit:
static void mirror_complete(Job *job, Error **errp)
{
MirrorBlockJob *s = container_of(job, MirrorBlockJob, common.job);
- BlockDriverState *target;
-
- target = blk_bs(s->target);
if (!s->synced) {
error_setg(errp, "The active block job '%s' cannot be completed",
@@ -1117,17 +1122,6 @@ static void mirror_complete(Job *job, Error **errp)
return;
}
- if (s->backing_mode == MIRROR_OPEN_BACKING_CHAIN) {
- int ret;
-
- assert(!bdrv_backing_chain_next(target));
- ret = bdrv_open_backing_file(bdrv_skip_filters(target), NULL,
- "backing", errp);
- if (ret < 0) {
- return;
- }
- }
-
/* block all operations on to_replace bs */
if (s->replaces) {
AioContext *replace_aio_context;
--
2.29.2
- [PATCH 0/4] job: Allow complete for jobs on standby, Max Reitz, 2021/04/09
- [PATCH 2/4] mirror: Do not enter a paused job on completion, Max Reitz, 2021/04/09
- [PATCH 1/4] mirror: Move open_backing_file to exit_common,
Max Reitz <=
- [PATCH 3/4] job: Allow complete for jobs on standby, Max Reitz, 2021/04/09
- [PATCH 4/4] test-blockjob: Test job_wait_unpaused(), Max Reitz, 2021/04/09
- [PATCH 5/4] iotests: Test completion immediately after drain, Max Reitz, 2021/04/09
- Re: [PATCH 0/4] job: Allow complete for jobs on standby, Kevin Wolf, 2021/04/09