[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/5] migration: add trace point when vm_stop_force_state fail
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [PATCH 1/5] migration: add trace point when vm_stop_force_state fails |
Date: |
Thu, 15 Apr 2021 17:30:28 +0100 |
User-agent: |
Mutt/2.0.6 (2021-03-06) |
* Daniel P. Berrangé (berrange@redhat.com) wrote:
> This is a critical failure scenario for migration that is hard to
> diagnose from existing probes. Most likely it is caused by an error
> from bdrv_flush(), but we're not logging the errno anywhere, hence
> this new probe.
>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> ---
> migration/migration.c | 1 +
> migration/trace-events | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/migration/migration.c b/migration/migration.c
> index 8ca034136b..bee0dcd501 100644
> --- a/migration/migration.c
> +++ b/migration/migration.c
> @@ -3121,6 +3121,7 @@ static void migration_completion(MigrationState *s)
> if (!ret) {
> bool inactivate = !migrate_colo_enabled();
> ret = vm_stop_force_state(RUN_STATE_FINISH_MIGRATE);
> + trace_migration_completion_vm_stop(ret);
> if (ret >= 0) {
> ret = migration_maybe_pause(s, ¤t_active_state,
> MIGRATION_STATUS_DEVICE);
> diff --git a/migration/trace-events b/migration/trace-events
> index 668c562fed..8ec28432eb 100644
> --- a/migration/trace-events
> +++ b/migration/trace-events
> @@ -149,6 +149,7 @@ migrate_pending(uint64_t size, uint64_t max, uint64_t
> pre, uint64_t compat, uint
> migrate_send_rp_message(int msg_type, uint16_t len) "%d: len %d"
> migrate_send_rp_recv_bitmap(char *name, int64_t size) "block '%s' size
> 0x%"PRIi64
> migration_completion_file_err(void) ""
> +migration_completion_vm_stop(int ret) "ret %d"
> migration_completion_postcopy_end(void) ""
> migration_completion_postcopy_end_after_complete(void) ""
> migration_rate_limit_pre(int ms) "%d ms"
> --
> 2.30.2
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
- [PATCH 0/5] block, migration: improve debugging of migration bdrv_flush failure, Daniel P . Berrangé, 2021/04/15
- [PATCH 1/5] migration: add trace point when vm_stop_force_state fails, Daniel P . Berrangé, 2021/04/15
- Re: [PATCH 1/5] migration: add trace point when vm_stop_force_state fails,
Dr. David Alan Gilbert <=
- [PATCH 2/5] softmmu: add trace point when bdrv_flush_all fails, Daniel P . Berrangé, 2021/04/15
- [PATCH 3/5] block: preserve errno from fdatasync failures, Daniel P . Berrangé, 2021/04/15
- [PATCH 4/5] block: add trace point when fdatasync fails, Daniel P . Berrangé, 2021/04/15
- [PATCH 5/5] block: remove duplicate trace.h include, Daniel P . Berrangé, 2021/04/15
- Re: [PATCH 0/5] block, migration: improve debugging of migration bdrv_flush failure, Connor Kuehl, 2021/04/15