Re: [PATCH v2] hw/block/nvme: align with existing style

[Gollu Appalanaidu]

On Thu, Apr 15, 2021 at 07:18:50PM +0200, Klaus Jensen wrote:
> On Apr 15 15:13, Philippe Mathieu-Daudé wrote:
> > On 4/15/21 2:00 PM, Gollu Appalanaidu wrote:
> > > Make uniform hexadecimal numbers format.
> > >
> > > Signed-off-by: Gollu Appalanaidu <anaidu.gollu@samsung.com>
> > > ---
> > > -v2: Address review comments (Klaus)
> > > use lower case hexa format for the code and in comments
> > > use the same format as used in Spec. ("FFFFFFFFh")
> >
> > ^ This comment is relevant to the commit message.
> >
> > Also it would be nice if the subsystem could describe somewhere
> > what is its style. Not sure where... The file header is probably
> > the simplest place.
> >
> > Something like:
> >
> > "While QEMU coding style prefers lowercase hexadecimal in constants,
> > the NVMe subsystem use the format from the NVMe specifications in
> > the comments: no '0x' prefix, uppercase, 'h' hexadecimal suffix."
>
> +1 for that suggestion.

Sure, will add it and send v3.

> > > hw/block/nvme-ns.c   |  2 +-
> > > hw/block/nvme.c      | 40 ++++++++++++++++++++--------------------
> > > include/block/nvme.h | 10 +++++-----
> > > 3 files changed, 26 insertions(+), 26 deletions(-)