Re: [PATCH 02/14] hw/block/nvme: rename __nvme_advance_zone_wp

[Thomas Huth]

On 19/04/2021 21.27, Klaus Jensen wrote:
> From: Klaus Jensen <k.jensen@samsung.com>
>
> Get rid of the (reserved) double underscore use.
>
> Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
> Cc: Thomas Huth <thuth@redhat.com>
> Signed-off-by: Klaus Jensen <k.jensen@samsung.com>
> ---
>   hw/block/nvme.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/hw/block/nvme.c b/hw/block/nvme.c
> index 002c0672b397..d1b94e36c6fb 100644
> --- a/hw/block/nvme.c
> +++ b/hw/block/nvme.c
> @@ -1745,8 +1745,8 @@ static inline uint16_t nvme_zrm_open(NvmeNamespace *ns, 
> NvmeZone *zone)
>       return nvme_zrm_open_flags(ns, zone, 0);
>   }
>   
> -static void __nvme_advance_zone_wp(NvmeNamespace *ns, NvmeZone *zone,
> -                                   uint32_t nlb)
> +static void nvme_advance_zone_wp(NvmeNamespace *ns, NvmeZone *zone,
> +                                 uint32_t nlb)
>   {
>       zone->d.wp += nlb;
>   
> @@ -1766,7 +1766,7 @@ static void nvme_finalize_zoned_write(NvmeNamespace *ns, NvmeRequest *req)
>       nlb = le16_to_cpu(rw->nlb) + 1;
>       zone = nvme_get_zone_by_slba(ns, slba);
>   
> -    __nvme_advance_zone_wp(ns, zone, nlb);
> +    nvme_advance_zone_wp(ns, zone, nlb);
>   }
>   
>   static inline bool nvme_is_write(NvmeRequest *req)
> @@ -2155,7 +2155,7 @@ out:
>           uint64_t sdlba = le64_to_cpu(copy->sdlba);
>           NvmeZone *zone = nvme_get_zone_by_slba(ns, sdlba);
>   
> -        __nvme_advance_zone_wp(ns, zone, ctx->nlb);
> +        nvme_advance_zone_wp(ns, zone, ctx->nlb);
>       }
>   
>       g_free(ctx->bounce);

Reviewed-by: Thomas Huth <thuth@redhat.com>