|
From: | Paolo Bonzini |
Subject: | Re: iotests and python dependencies |
Date: | Thu, 5 May 2022 11:28:54 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 |
On 5/5/22 10:51, Kevin Wolf wrote:
If not, I guess it would be enough if iotests just checks that the venv exists and all of the dependencies are there in the right version and error out if not, telling the user to run 'make check-venv'. Or actually, it could just unconditionally run 'make check-venv' by itself, which is probably easier to implement than checking the dependencies and more convenient for the user, too.
Note that you would still have to add a 'check-block: check-venv' dependency in the Makefile, otherwise two "instances" of check-venv could run in parallel.
One small complication is that on BSD systems the binary is actually called "gmake", so you'd have to pass the variable somehow
Paolo
[Prev in Thread] | Current Thread | [Next in Thread] |