[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 03/15] tests: make libqmp buildable for win32
From: |
Marc-André Lureau |
Subject: |
Re: [PATCH v2 03/15] tests: make libqmp buildable for win32 |
Date: |
Thu, 5 May 2022 15:08:15 +0400 |
Hi
On Thu, May 5, 2022 at 2:52 PM Markus Armbruster <armbru@redhat.com> wrote:
>
> marcandre.lureau@redhat.com writes:
>
> > From: Marc-André Lureau <marcandre.lureau@redhat.com>
> >
> > Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> > Reviewed-by: Thomas Huth <thuth@redhat.com>
> > ---
> > tests/qtest/libqmp.h | 2 ++
> > tests/qtest/libqmp.c | 35 +++++++++++++++++++++++++++++------
> > 2 files changed, 31 insertions(+), 6 deletions(-)
> >
> > diff --git a/tests/qtest/libqmp.h b/tests/qtest/libqmp.h
> > index 94aa97328a17..772f18b73ba3 100644
> > --- a/tests/qtest/libqmp.h
> > +++ b/tests/qtest/libqmp.h
> > @@ -20,8 +20,10 @@
> > #include "qapi/qmp/qdict.h"
> >
> > QDict *qmp_fd_receive(int fd);
> > +#ifndef G_OS_WIN32
>
> What's the difference between G_OS_WIN32 and _WIN32?
>
> We have 10 of the former, but >250 of the latter. If they are
> effectively the same, we should pick one and stick to it.
There are some subtle differences when compiling for cygwin, in which
case G_OS_WIN32 is not defined.
I usually pick G_OS_{UNIX,WIN32} defines, mostly for consistency, but
in many situation _WIN32/WIN32 is fine.
(and we also have CONFIG_WIN32)
- [PATCH v2 00/15] Misc cleanups, marcandre . lureau, 2022/05/05
- [PATCH v2 05/15] qga: flatten safe_open_or_create(), marcandre . lureau, 2022/05/05
- [PATCH v2 04/15] include: adjust header guards after renaming, marcandre . lureau, 2022/05/05
- [PATCH v2 07/15] qga: use qemu_open_cloexec() for safe_open_or_create(), marcandre . lureau, 2022/05/05
- [PATCH v2 06/15] osdep: export qemu_open_cloexec(), marcandre . lureau, 2022/05/05