[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v12 2/7] QIOChannelSocket: Implement io_writev zero copy flag
From: |
Peter Xu |
Subject: |
Re: [PATCH v12 2/7] QIOChannelSocket: Implement io_writev zero copy flag & io_flush for CONFIG_LINUX |
Date: |
Sat, 7 May 2022 15:12:56 -0400 |
On Fri, May 06, 2022 at 10:57:54PM -0300, Leonardo Bras wrote:
> diff --git a/io/channel-socket.c b/io/channel-socket.c
> index 05c425abb8..f03a068f25 100644
> --- a/io/channel-socket.c
> +++ b/io/channel-socket.c
> @@ -25,9 +25,18 @@
> #include "io/channel-watch.h"
> #include "trace.h"
> #include "qapi/clone-visitor.h"
> +#ifdef CONFIG_LINUX
> +#include <linux/errqueue.h>
> +#include <sys/socket.h>
> +
> +#if (defined(MSG_ZEROCOPY) && defined(SO_ZEROCOPY))
> +#define QEMU_MSG_ZEROCOPY
> +#endif
> +#endif
>
> #define SOCKET_MAX_FDS 16
>
> +
This line can be dropped when merge.
> SocketAddress *
> qio_channel_socket_get_local_address(QIOChannelSocket *ioc,
> Error **errp)
This does look nicer, imho. :)
Thanks!
--
Peter Xu
- [PATCH v12 0/7] MSG_ZEROCOPY + multifd, Leonardo Bras, 2022/05/06
- [PATCH v12 1/7] QIOChannel: Add flags on io_writev and introduce io_flush callback, Leonardo Bras, 2022/05/06
- [PATCH v12 2/7] QIOChannelSocket: Implement io_writev zero copy flag & io_flush for CONFIG_LINUX, Leonardo Bras, 2022/05/06
- Re: [PATCH v12 2/7] QIOChannelSocket: Implement io_writev zero copy flag & io_flush for CONFIG_LINUX,
Peter Xu <=
- [PATCH v12 3/7] migration: Add zero-copy-send parameter for QMP/HMP for Linux, Leonardo Bras, 2022/05/06
- [PATCH v12 4/7] migration: Add migrate_use_tls() helper, Leonardo Bras, 2022/05/06
- [PATCH v12 5/7] multifd: multifd_send_sync_main now returns negative on error, Leonardo Bras, 2022/05/06
- [PATCH v12 6/7] multifd: Send header packet without flags if zero-copy-send is enabled, Leonardo Bras, 2022/05/06
- [PATCH v12 7/7] multifd: Implement zero copy write in multifd migration (multifd-zero-copy), Leonardo Bras, 2022/05/06