[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH 11/17] hw/sd: Add eMMC support
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [RFC PATCH 11/17] hw/sd: Add eMMC support |
Date: |
Mon, 9 May 2022 23:17:25 +0200 |
User-agent: |
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 |
Hi Cédric,
On 18/3/22 14:28, Cédric Le Goater wrote:
The initial eMMC support from Vincent Palatin was largely reworked to
match the current SD framework. The parameters mimick a real 4GB eMMC,
but it can be set to various sizes.
This adds a new QOM object class for EMMC devices.
Signed-off-by: Vincent Palatin <vpalatin@chromium.org>
Link:
https://lore.kernel.org/r/1311635951-11047-5-git-send-email-vpalatin@chromium.org
[ jms: - Forward ported to QEMU 5.2 ]
Signed-off-by: Joel Stanley <joel@jms.id.au>
[ clg: - ported on aspeed-7.0 patchset
- HPI activation ]
Signed-off-by: Cédric Le Goater <clg@kaod.org>
---
hw/sd/sdmmc-internal.h | 97 +++++++++++++++++++
include/hw/sd/sd.h | 9 ++
hw/sd/sd.c | 205 ++++++++++++++++++++++++++++++++++++++++-
hw/sd/sdmmc-internal.c | 2 +-
4 files changed, 311 insertions(+), 2 deletions(-)
Do you mind splitting as:
- Add TYPE_EMMC, emmc_class_init and sd_proto_emmc[] with
already existing handlers (1 patch)
- Add new handlers, from smaller to sd_emmc_set_csd(),
and finally mmc_set_ext_csd() with the EXT_CSD definitions
(various patches).
Otherwise LGTM!
What is your test suite?
Thanks,
Phil.