[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 8/8] libvduse: Add support for reconnecting
From: |
Yongji Xie |
Subject: |
Re: [PATCH v5 8/8] libvduse: Add support for reconnecting |
Date: |
Thu, 19 May 2022 16:25:13 +0800 |
On Wed, May 18, 2022 at 10:03 PM Stefan Hajnoczi <stefanha@redhat.com> wrote:
>
> On Wed, May 04, 2022 at 03:40:51PM +0800, Xie Yongji wrote:
> > @@ -291,6 +294,15 @@ static int vduse_blk_exp_create(BlockExport *exp,
> > BlockExportOptions *opts,
> > return -ENOMEM;
> > }
> >
> > + vblk_exp->recon_file = g_strdup_printf("%s/vduse-blk-%s",
> > + g_get_tmp_dir(), exp->id);
>
> g_get_tmp_dir() returns the $TMPDIR environment variable. This means
> exp->id must be unique across the host. Please document this.
>
Now we also use exp->id as the name of vduse device which should also
be unique across the host. So I'm not sure if it's better to add a new
unique id for vduse since the exp->id is now used by all block
exports.
Thanks,
Yongji
- Re: [PATCH v5 1/8] block: Support passing NULL ops to blk_set_dev_ops(), (continued)
[PATCH v5 3/8] block/export: Abstract out the logic of virtio-blk I/O process, Xie Yongji, 2022/05/04
[PATCH v5 6/8] vduse-blk: Implement vduse-blk export, Xie Yongji, 2022/05/04
[PATCH v5 5/8] libvduse: Add VDUSE (vDPA Device in Userspace) library, Xie Yongji, 2022/05/04