[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v6 2/8] block/export: Fix incorrect length passed to vu_queue_pus
From: |
Xie Yongji |
Subject: |
[PATCH v6 2/8] block/export: Fix incorrect length passed to vu_queue_push() |
Date: |
Mon, 23 May 2022 16:46:05 +0800 |
Now the req->size is set to the correct value only
when handling VIRTIO_BLK_T_GET_ID request. This patch
fixes it.
Signed-off-by: Xie Yongji <xieyongji@bytedance.com>
---
block/export/vhost-user-blk-server.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/block/export/vhost-user-blk-server.c
b/block/export/vhost-user-blk-server.c
index b2e458ade3..19c6ee51d3 100644
--- a/block/export/vhost-user-blk-server.c
+++ b/block/export/vhost-user-blk-server.c
@@ -60,8 +60,7 @@ static void vu_blk_req_complete(VuBlkReq *req)
{
VuDev *vu_dev = &req->server->vu_dev;
- /* IO size with 1 extra status byte */
- vu_queue_push(vu_dev, req->vq, &req->elem, req->size + 1);
+ vu_queue_push(vu_dev, req->vq, &req->elem, req->size);
vu_queue_notify(vu_dev, req->vq);
free(req);
@@ -207,6 +206,7 @@ static void coroutine_fn vu_blk_virtio_process_req(void
*opaque)
goto err;
}
+ req->size = iov_size(in_iov, in_num);
/* We always touch the last byte, so just see how big in_iov is. */
req->in = (void *)in_iov[in_num - 1].iov_base
+ in_iov[in_num - 1].iov_len
@@ -267,7 +267,6 @@ static void coroutine_fn vu_blk_virtio_process_req(void
*opaque)
VIRTIO_BLK_ID_BYTES);
snprintf(elem->in_sg[0].iov_base, size, "%s", "vhost_user_blk");
req->in->status = VIRTIO_BLK_S_OK;
- req->size = elem->in_sg[0].iov_len;
break;
}
case VIRTIO_BLK_T_DISCARD:
--
2.20.1
- [PATCH v6 0/8] Support exporting BDSs via VDUSE, Xie Yongji, 2022/05/23
- [PATCH v6 4/8] linux-headers: Add vduse.h, Xie Yongji, 2022/05/23
- [PATCH v6 3/8] block/export: Abstract out the logic of virtio-blk I/O process, Xie Yongji, 2022/05/23
- [PATCH v6 1/8] block: Support passing NULL ops to blk_set_dev_ops(), Xie Yongji, 2022/05/23
- [PATCH v6 5/8] libvduse: Add VDUSE (vDPA Device in Userspace) library, Xie Yongji, 2022/05/23
- [PATCH v6 6/8] vduse-blk: Implement vduse-blk export, Xie Yongji, 2022/05/23
- [PATCH v6 2/8] block/export: Fix incorrect length passed to vu_queue_push(),
Xie Yongji <=
- [PATCH v6 8/8] libvduse: Add support for reconnecting, Xie Yongji, 2022/05/23
- [PATCH v6 7/8] vduse-blk: Add vduse-blk resize support, Xie Yongji, 2022/05/23
- Re: [PATCH v6 0/8] Support exporting BDSs via VDUSE, Stefan Hajnoczi, 2022/05/25
- Re: [PATCH v6 0/8] Support exporting BDSs via VDUSE, Stefan Hajnoczi, 2022/05/25
- Re: [PATCH v6 0/8] Support exporting BDSs via VDUSE, Kevin Wolf, 2022/05/27