[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 00/25] hw/sd: Rework models for eMMC support
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH v2 00/25] hw/sd: Rework models for eMMC support |
Date: |
Tue, 31 May 2022 21:07:25 +0200 |
User-agent: |
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 |
On 31/5/22 11:19, Cédric Le Goater wrote:
On 5/30/22 21:37, Philippe Mathieu-Daudé wrote:
From: Philippe Mathieu-Daudé <f4bug@amsat.org>
Rebase/respin of Cédric RFC:
https://lore.kernel.org/qemu-devel/20220318132824.1134400-1-clg@kaod.org/
(sorry it took me so long guys...)
Pushed at https://gitlab.com/philmd/qemu/-/commits/emmc-v2
I plan to queue patches 1-12 via sdmmc-next later this week.
Cédric, if you are happy with this series, it should be easy to rebase
your other patches on top and address the comments I left on the RFC :)
I pushed an update on :
https://github.com/legoater/qemu/commits/aspeed-7.1
Here is an image :
https://www.kaod.org/qemu/aspeed/mmc-p10bmc.qcow2
run with :
qemu-system-arm -M rainier-bmc -net nic -net user -drive
file=./mmc-p10bmc.qcow2,format=qcow2,if=sd,id=sd0,index=2 -nographic
-nodefaults -snapshot -serial mon:stdio
Useful, thanks.
I see in hw/arm/aspeed_ast2600.c:
/* Init sd card slot class here so that they're under the correct
parent */
for (i = 0; i < ASPEED_SDHCI_NUM_SLOTS; ++i) {
object_initialize_child(obj, "sd-controller.sdhci[*]",
&s->sdhci.slots[i], TYPE_SYSBUS_SDHCI);
}
object_initialize_child(obj, "emmc-controller.sdhci",
&s->emmc.slots[0],
TYPE_SYSBUS_SDHCI);
/* eMMC Boot Controller stub */
create_unimplemented_device("aspeed.emmc-boot-controller",
sc->memmap[ASPEED_DEV_EMMC_BC],
0x1000);
/* eMMC */
if (!sysbus_realize(SYS_BUS_DEVICE(&s->emmc), errp)) {
return;
}
sysbus_mmio_map(SYS_BUS_DEVICE(&s->emmc), 0,
sc->memmap[ASPEED_DEV_EMMC]);
sysbus_connect_irq(SYS_BUS_DEVICE(&s->emmc), 0,
aspeed_soc_get_irq(s, ASPEED_DEV_EMMC));
Where is 'emmc-controller.sdhci' realized?
In aspeed_sdhci_realize() you set sd-spec-version" = 2, is that OK
with eMMC?
What expects the real hw?
Thanks,
Phil.
- [PATCH v2 21/25] hw/sd: Add mmc switch function support, (continued)
- [PATCH v2 21/25] hw/sd: Add mmc switch function support, Philippe Mathieu-Daudé, 2022/05/30
- [PATCH v2 22/25] hw/sd: Add sd_emmc_cmd_SEND_EXT_CSD() handler, Philippe Mathieu-Daudé, 2022/05/30
- [PATCH v2 23/25] hw/sd: Support boot area in emmc image, Philippe Mathieu-Daudé, 2022/05/30
- [PATCH v2 24/25] hw/sd: Subtract bootarea size from blk, Philippe Mathieu-Daudé, 2022/05/30
- [PATCH v2 25/25] hw/sd: Add boot config support, Philippe Mathieu-Daudé, 2022/05/30
- Re: [PATCH v2 00/25] hw/sd: Rework models for eMMC support, Cédric Le Goater, 2022/05/31
- Re: [PATCH v2 00/25] hw/sd: Rework models for eMMC support, Cédric Le Goater, 2022/05/31
- Re: [PATCH v2 00/25] hw/sd: Rework models for eMMC support,
Philippe Mathieu-Daudé <=