Re: [PATCH] qapi/block-core: Fix BlockdevOptionsNvmeIoUring @path description

[Stefano Garzarella]

On Tue, Nov 08, 2022 at 02:23:47PM +0000, Alberto Faria wrote:
> The nvme-io_uring BlockDriver's path option must point at the character
> device of an NVMe namespace, not at an image file.
>
> Fixes: fd66dbd424f5 ("blkio: add libblkio block driver")
> Suggested-by: Stefano Garzarella <sgarzare@redhat.com>
> Signed-off-by: Alberto Faria <afaria@redhat.com>
> ---
> qapi/block-core.json | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Thanks for fixing this:

Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>

> diff --git a/qapi/block-core.json b/qapi/block-core.json
> index 6d904004f8..95ac4fa634 100644
> --- a/qapi/block-core.json
> +++ b/qapi/block-core.json
> @@ -3704,7 +3704,7 @@
> #
> # Driver specific block device options for the nvme-io_uring backend.
> #
> -# @path: path to the image file
> +# @path: path to the NVMe namespace's character device (e.g. /dev/ng0n1).
> #
> # Since: 7.2
> ##
> --
> 2.38.1