Re: [PATCH 07/13] block: Don't use subtree drains in bdrv_drop

qemu-block

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 07/13] block: Don't use subtree drains in bdrv_drop_intermedi

From:	Vladimir Sementsov-Ogievskiy
Subject:	Re: [PATCH 07/13] block: Don't use subtree drains in bdrv_drop_intermediate()
Date:	Wed, 9 Nov 2022 19:18:50 +0300
User-agent:	Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2

On 11/8/22 15:37, Kevin Wolf wrote:

Instead of using a subtree drain from the top node (which also drains
child nodes of base that we're not even interested in), use a normal
drain for base, which automatically drains all of the parents, too.

Signed-off-by: Kevin Wolf<kwolf@redhat.com>


Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>

--
Best regards,
Vladimir

[Prev in Thread]

Current Thread

[Next in Thread]

[PATCH 06/13] block: Drain invidual nodes during reopen, (continued)
- [PATCH 06/13] block: Drain invidual nodes during reopen, Kevin Wolf, 2022/11/08
  - Re: [PATCH 06/13] block: Drain invidual nodes during reopen, Vladimir Sementsov-Ogievskiy, 2022/11/09
    - Re: [PATCH 06/13] block: Drain invidual nodes during reopen, Kevin Wolf, 2022/11/11
- [PATCH 02/13] test-bdrv-drain: Don't yield in .bdrv_co_drained_begin/end(), Kevin Wolf, 2022/11/08
  - Re: [PATCH 02/13] test-bdrv-drain: Don't yield in .bdrv_co_drained_begin/end(), Vladimir Sementsov-Ogievskiy, 2022/11/09
    - Re: [PATCH 02/13] test-bdrv-drain: Don't yield in .bdrv_co_drained_begin/end(), Kevin Wolf, 2022/11/09
  - Re: [PATCH 02/13] test-bdrv-drain: Don't yield in .bdrv_co_drained_begin/end(), Vladimir Sementsov-Ogievskiy, 2022/11/09
  - Re: [PATCH 02/13] test-bdrv-drain: Don't yield in .bdrv_co_drained_begin/end(), Emanuele Giuseppe Esposito, 2022/11/11
  - Re: [PATCH 02/13] test-bdrv-drain: Don't yield in .bdrv_co_drained_begin/end(), Hanna Reitz, 2022/11/14
- [PATCH 07/13] block: Don't use subtree drains in bdrv_drop_intermediate(), Kevin Wolf, 2022/11/08
  - Re: [PATCH 07/13] block: Don't use subtree drains in bdrv_drop_intermediate(), Vladimir Sementsov-Ogievskiy <=
  - Re: [PATCH 07/13] block: Don't use subtree drains in bdrv_drop_intermediate(), Hanna Reitz, 2022/11/14
- [PATCH 10/13] block: Call drain callbacks only once, Kevin Wolf, 2022/11/08
  - Re: [PATCH 10/13] block: Call drain callbacks only once, Vladimir Sementsov-Ogievskiy, 2022/11/09
    - Re: [PATCH 10/13] block: Call drain callbacks only once, Kevin Wolf, 2022/11/14
  - Re: [PATCH 10/13] block: Call drain callbacks only once, Vladimir Sementsov-Ogievskiy, 2022/11/09
  - Re: [PATCH 10/13] block: Call drain callbacks only once, Hanna Reitz, 2022/11/14
- [PATCH 08/13] stream: Replace subtree drain with a single node drain, Kevin Wolf, 2022/11/08
  - Re: [PATCH 08/13] stream: Replace subtree drain with a single node drain, Vladimir Sementsov-Ogievskiy, 2022/11/09
    - Re: [PATCH 08/13] stream: Replace subtree drain with a single node drain, Kevin Wolf, 2022/11/10
    - Re: [PATCH 08/13] stream: Replace subtree drain with a single node drain, Vladimir Sementsov-Ogievskiy, 2022/11/10

Prev by Date: Re: [PATCH 06/13] block: Drain invidual nodes during reopen
Next by Date: Re: [PATCH 08/13] stream: Replace subtree drain with a single node drain
Previous by thread: [PATCH 07/13] block: Don't use subtree drains in bdrv_drop_intermediate()
Next by thread: Re: [PATCH 07/13] block: Don't use subtree drains in bdrv_drop_intermediate()
Index(es):
- Date
- Thread