Re: [PATCH v2 2/2] file-posix: add statx(STATX_DIOALIGN) support

[Kevin Wolf]

Am 03.11.2022 um 19:36 hat Stefan Hajnoczi geschrieben:
> Linux v6.1 commit 825cf206ed51 ("statx: add direct I/O alignment
> information") added an interface to fetch O_DIRECT alignment values for
> block devices and file systems.
> 
> Prefer STATX_DIOALIGN to older interfaces and probing, but keep them as
> fallbacks in case STATX_DIOALIGN cannot provide the information.
> 
> Testing shows the status of STATX_DIOALIGN support in Linux 6.1-rc3
> appears to be:
> - btrfs: no
> - ext4: yes
> - XFS: yes
> - NVMe block devices: yes
> - dm-crypt: yes
> 
> Cc: Eric Biggers <ebiggers@google.com>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>

I think it's worth noting in the commit message that this essentially
disables patch 1 again on Linux 6.1 because it doesn't even use the code
any more that patch 1 modified to work around the dm-crypt bug.

This is only okay because we think that the final 6.1 release is going
to have the bug fixed, and it's also the first version to support
STATX_DIOALIGN, so you won't have both STATX_DIOALIGN and the bug in a
stable kernel.

Kevin