[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/8] virtio: categorize callbacks in GS
From: |
Emanuele Giuseppe Esposito |
Subject: |
Re: [PATCH 3/8] virtio: categorize callbacks in GS |
Date: |
Fri, 11 Nov 2022 13:19:41 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 |
Am 08/11/2022 um 22:19 schrieb Stefan Hajnoczi:
> From: Emanuele Giuseppe Esposito <eesposit@redhat.com>
>
> All the callbacks below are always running in the main loop.
>
> The callbacks are the following:
> - start/stop_ioeventfd: these are the callbacks where
> blk_set_aio_context(iothread) is done, so they are called in the main
> loop.
>
> - save and load: called during migration, when VM is stopped from the
> main loop.
>
> - reset: before calling this callback, stop_ioeventfd is invoked, so
> it can only run in the main loop.
>
> - set_status: going through all the callers we can see it is called
> from a MemoryRegionOps callback, which always run in a vcpu thread and
> hold the BQL.
>
> - realize: iothread is not even created yet.
>
> Signed-off-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
> Acked-by: Michael S. Tsirkin <mst@redhat.com>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> Message-Id: <20220609143727.1151816-5-eesposit@redhat.com>
>
Reviewed-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
- [PATCH 0/8] virtio-blk: remove AioContext lock, Stefan Hajnoczi, 2022/11/08
- [PATCH 2/8] block-backend: enable_write_cache should be atomic, Stefan Hajnoczi, 2022/11/08
- [PATCH 1/8] virtio_queue_aio_attach_host_notifier: remove AioContext lock, Stefan Hajnoczi, 2022/11/08
- [PATCH 3/8] virtio: categorize callbacks in GS, Stefan Hajnoczi, 2022/11/08
- Re: [PATCH 3/8] virtio: categorize callbacks in GS,
Emanuele Giuseppe Esposito <=
- [PATCH 4/8] virtio-blk: mark GLOBAL_STATE_CODE functions, Stefan Hajnoczi, 2022/11/08
- [PATCH 5/8] virtio-blk: mark IO_CODE functions, Stefan Hajnoczi, 2022/11/08
- [PATCH 7/8] virtio-blk: don't acquire AioContext in virtio_blk_handle_vq(), Stefan Hajnoczi, 2022/11/08
- [PATCH 6/8] virtio-blk: remove unnecessary AioContext lock from function already safe, Stefan Hajnoczi, 2022/11/08
- [PATCH 8/8] virtio-blk: minimize virtio_blk_reset() AioContext lock region, Stefan Hajnoczi, 2022/11/08