[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 3/3] nvme: Add physical writes/reads from OCP log
|
From: |
Klaus Jensen |
|
Subject: |
Re: [PATCH v2 3/3] nvme: Add physical writes/reads from OCP log |
|
Date: |
Thu, 17 Nov 2022 07:36:15 +0100 |
On Nov 16 17:19, Joel Granados wrote:
> On Tue, Nov 15, 2022 at 12:26:17PM +0100, Klaus Jensen wrote:
> > On Nov 14 14:50, Joel Granados wrote:
> > >
> > > +static uint16_t nvme_vendor_specific_log(uint8_t lid, NvmeCtrl *n,
> > > uint8_t rae,
> > > + uint32_t buf_len, uint64_t off,
> > > + NvmeRequest *req)
> >
> > `NvmeCtrl *n` must be first parameter.
> Any reason why this is the case? I'll change it in my code, but would be
> nice to understand the reason.
>
No other reason than consistency with existing code.
signature.asc
Description: PGP signature