Re: [PATCH RFC 3/3] hw/nvme: add nvme management interface model

[Philippe Mathieu-Daudé]

On 16/11/22 09:43, Klaus Jensen wrote:
> From: Klaus Jensen <k.jensen@samsung.com>
>
> Add the 'nmi-i2c' device that emulates an NVMe Management Interface
> controller.
>
> Initial support is very basic (Read NMI DS, Configuration Get).
>
> This is based on previously posted code by Padmakar Kalghatgi, Arun
> Kumar Agasar and Saurav Kumar.
>
> Signed-off-by: Klaus Jensen <k.jensen@samsung.com>
> ---
>   hw/nvme/meson.build  |   1 +
>   hw/nvme/nmi-i2c.c    | 381 +++++++++++++++++++++++++++++++++++++++++++
>   hw/nvme/trace-events |   6 +
>   3 files changed, 388 insertions(+)
>   create mode 100644 hw/nvme/nmi-i2c.c

> +++ b/hw/nvme/nmi-i2c.c
> @@ -0,0 +1,381 @@
> +/*
> + * SPDX-License-Identifier: GPL-2.0-only

Just curious, is this restricted license choice on purpose?

> + *
> + * SPDX-FileCopyrightText: Copyright (c) 2022 Samsung Electronics Co., Ltd.
> + *
> + * SPDX-FileContributor: Padmakar Kalghatgi <p.kalghatgi@samsung.com>
> + * SPDX-FileContributor: Arun Kumar Agasar <arun.kka@samsung.com>
> + * SPDX-FileContributor: Saurav Kumar <saurav.29@partner.samsung.com>
> + * SPDX-FileContributor: Klaus Jensen <k.jensen@samsung.com>
> + */