Re: [PATCH v6 02/14] block-copy: add missing coroutine_fn annotations

[Vladimir Sementsov-Ogievskiy]

On 11/25/22 16:35, Emanuele Giuseppe Esposito wrote:
> These functions end up calling bdrv_common_block_status_above(), a
> generated_co_wrapper function.
> In addition, they also happen to be always called in coroutine context,
> meaning all callers are coroutine_fn.
> This means that the g_c_w function will enter the qemu_in_coroutine()
> case and eventually suspend (or in other words call qemu_coroutine_yield()).
> Therefore we need to mark such functions coroutine_fn too.

I still think that "we need to mark" is not quite correct. Actually "we can 
mark", as such marking doesn't brake things. And we do have a reason for it, which comes in 
the following patches, but the commit message say nothing about it.

As well as in subject: they are not "missing", as nothing wrong for function not to be 
"coroutine_fn", when it doesn't call other "coroutine_fn"s.

> Signed-off-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
> Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
> Reviewed-by: Kevin Wolf <kwolf@redhat.com>

change is OK:
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>

--
Best regards,
Vladimir