[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-7.2] vhost: enable vrings in vhost_dev_start() for vhost-
From: |
Michael S. Tsirkin |
Subject: |
Re: [PATCH for-7.2] vhost: enable vrings in vhost_dev_start() for vhost-user devices |
Date: |
Thu, 1 Dec 2022 16:49:37 -0500 |
On Thu, Dec 01, 2022 at 12:21:21PM +0000, Alex Bennée wrote:
>
> "Michael S. Tsirkin" <mst@redhat.com> writes:
>
> > On Thu, Dec 01, 2022 at 10:14:39AM +0000, Alex Bennée wrote:
> >> Do you think rust-vmm's vhost crates have enough of the state
> >> management to manage vhost and vhost-user backends? Maybe it would be a
> >> good experiment in replacing a (small well defined) piece of
> >> functionality with rust?
> >>
> >> That said there is a lot of deep magic in the vhost-net stuff which I
> >> think is down to the interaction with things like vdpk and other network
> >> optimisations that might be missing. For the rest of the devices most of
> >> the code is basically boiler plate which has grown variations due to
> >> code motion and change. This is the sort of thing that generics solves
> >> well.
> >
> > Not sure what you want to replace with what though, libvhost-user or
> > vhost-user bits in qemu?
>
> The vhost-user bits in the main QEMU binary. We already don't use
> libvhost-user for most of our backends anyway ;-)
Mixing C and Rust like this is far from trivial. I'd start with
something much less ambitious that virtio.
--
MST