|
From: | Vladimir Sementsov-Ogievskiy |
Subject: | Re: [PATCH 05/14] block: Convert bdrv_refresh_total_sectors() to co_wrapper_mixed |
Date: | Fri, 16 Dec 2022 20:19:19 +0300 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 |
On 12/13/22 11:53, Kevin Wolf wrote:
--- a/include/block/block_int-common.h +++ b/include/block/block_int-common.h @@ -684,7 +684,7 @@ struct BlockDriver { int coroutine_fn (*bdrv_co_truncate)(BlockDriverState *bs, int64_t offset, bool exact, PreallocMode prealloc, BdrvRequestFlags flags, Error **errp); - int64_t (*bdrv_getlength)(BlockDriverState *bs); + int64_t coroutine_fn (*bdrv_getlength)(BlockDriverState *bs);
Like in 02 and 03, realizations of the callback are not marked coroutine_fn. [*] (do we want to reanme it to _co_ ? This also simplifies review, in a way to check [*]) -- Best regards, Vladimir
[Prev in Thread] | Current Thread | [Next in Thread] |