[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 01/32] hw/mips/malta: Introduce PIIX4_PCI_DEVFN definition
From: |
Igor Mammedov |
Subject: |
Re: [PATCH 01/32] hw/mips/malta: Introduce PIIX4_PCI_DEVFN definition |
Date: |
Mon, 19 Dec 2022 10:19:33 +0100 |
On Sun, 4 Dec 2022 20:05:22 +0100
Bernhard Beschow <shentey@gmail.com> wrote:
> From: Philippe Mathieu-Daudé <philmd@linaro.org>
>
> The PIIX4 PCI-ISA bridge function is always located at 10:0.
> Since we want to re-use its address, add the PIIX4_PCI_DEVFN
> definition.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> Message-Id: <20221027204720.33611-2-philmd@linaro.org>
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
> ---
> hw/mips/malta.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/hw/mips/malta.c b/hw/mips/malta.c
> index c0a2e0ab04..9bffa1b128 100644
> --- a/hw/mips/malta.c
> +++ b/hw/mips/malta.c
> @@ -71,6 +71,8 @@
>
> #define FLASH_SIZE 0x400000
>
> +#define PIIX4_PCI_DEVFN PCI_DEVFN(10, 0)
> +
> typedef struct {
> MemoryRegion iomem;
> MemoryRegion iomem_lo; /* 0 - 0x900 */
> @@ -1401,7 +1403,7 @@ void mips_malta_init(MachineState *machine)
> empty_slot_init("GT64120", 0, 0x20000000);
>
> /* Southbridge */
> - piix4 = pci_create_simple_multifunction(pci_bus, PCI_DEVFN(10, 0), true,
> + piix4 = pci_create_simple_multifunction(pci_bus, PIIX4_PCI_DEVFN, true,
> TYPE_PIIX4_PCI_DEVICE);
> isa_bus = ISA_BUS(qdev_get_child_bus(DEVICE(piix4), "isa.0"));
>
- [PATCH 00/32] Consolidate PIIX south bridges, Bernhard Beschow, 2022/12/04
- [PATCH 01/32] hw/mips/malta: Introduce PIIX4_PCI_DEVFN definition, Bernhard Beschow, 2022/12/04
- Re: [PATCH 01/32] hw/mips/malta: Introduce PIIX4_PCI_DEVFN definition,
Igor Mammedov <=
- [PATCH 02/32] hw/mips/malta: Set PIIX4 IRQ routes in embedded bootloader, Bernhard Beschow, 2022/12/04
- [PATCH 03/32] hw/isa/piix4: Correct IRQRC[A:D] reset values, Bernhard Beschow, 2022/12/04
- [PATCH 04/32] hw/mips/Kconfig: Track Malta's PIIX dependencies via Kconfig, Bernhard Beschow, 2022/12/04
- [PATCH 05/32] hw/i386/pc_piix: Allow for setting properties before realizing PIIX3 south bridge, Bernhard Beschow, 2022/12/04
- [PATCH 06/32] hw/usb/hcd-uhci: Introduce TYPE_ defines for device models, Bernhard Beschow, 2022/12/04
- [PATCH 07/32] hw/i386/pc: Create RTC controllers in south bridges, Bernhard Beschow, 2022/12/04
- [PATCH 08/32] hw/i386/pc: No need for rtc_state to be an out-parameter, Bernhard Beschow, 2022/12/04
- [PATCH 09/32] hw/isa/piix3: Create USB controller in host device, Bernhard Beschow, 2022/12/04