[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 2/6] hw/xen: use G_GNUC_PRINTF/SCANF for various functions
From: |
Daniel P . Berrangé |
Subject: |
[PATCH 2/6] hw/xen: use G_GNUC_PRINTF/SCANF for various functions |
Date: |
Mon, 19 Dec 2022 08:02:01 -0500 |
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
hw/xen/xen-bus.c | 1 +
hw/xen/xen_pvdev.c | 1 +
include/hw/xen/xen-bus-helper.h | 6 ++++--
include/hw/xen/xen-bus.h | 3 ++-
4 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/hw/xen/xen-bus.c b/hw/xen/xen-bus.c
index 645a29a5a0..df3f6b9ae0 100644
--- a/hw/xen/xen-bus.c
+++ b/hw/xen/xen-bus.c
@@ -561,6 +561,7 @@ void xen_device_backend_printf(XenDevice *xendev, const
char *key,
}
}
+G_GNUC_SCANF(3, 4)
static int xen_device_backend_scanf(XenDevice *xendev, const char *key,
const char *fmt, ...)
{
diff --git a/hw/xen/xen_pvdev.c b/hw/xen/xen_pvdev.c
index 037152f063..1a5177b354 100644
--- a/hw/xen/xen_pvdev.c
+++ b/hw/xen/xen_pvdev.c
@@ -196,6 +196,7 @@ const char *xenbus_strstate(enum xenbus_state state)
* 2 == noisy debug messages (logfile only).
* 3 == will flood your log (logfile only).
*/
+G_GNUC_PRINTF(3, 0)
static void xen_pv_output_msg(struct XenLegacyDevice *xendev,
FILE *f, const char *fmt, va_list args)
{
diff --git a/include/hw/xen/xen-bus-helper.h b/include/hw/xen/xen-bus-helper.h
index 629a904d1a..8782f30550 100644
--- a/include/hw/xen/xen-bus-helper.h
+++ b/include/hw/xen/xen-bus-helper.h
@@ -31,10 +31,12 @@ void xs_node_printf(struct xs_handle *xsh,
xs_transaction_t tid,
/* Read from node/key unless node is empty, in which case read from key */
int xs_node_vscanf(struct xs_handle *xsh, xs_transaction_t tid,
const char *node, const char *key, Error **errp,
- const char *fmt, va_list ap);
+ const char *fmt, va_list ap)
+ G_GNUC_SCANF(6, 0);
int xs_node_scanf(struct xs_handle *xsh, xs_transaction_t tid,
const char *node, const char *key, Error **errp,
- const char *fmt, ...);
+ const char *fmt, ...)
+ G_GNUC_SCANF(6, 7);
/* Watch node/key unless node is empty, in which case watch key */
void xs_node_watch(struct xs_handle *xsh, const char *node, const char *key,
diff --git a/include/hw/xen/xen-bus.h b/include/hw/xen/xen-bus.h
index 713e763348..4d966a2dbb 100644
--- a/include/hw/xen/xen-bus.h
+++ b/include/hw/xen/xen-bus.h
@@ -94,7 +94,8 @@ void xen_device_frontend_printf(XenDevice *xendev, const char
*key,
G_GNUC_PRINTF(3, 4);
int xen_device_frontend_scanf(XenDevice *xendev, const char *key,
- const char *fmt, ...);
+ const char *fmt, ...)
+ G_GNUC_SCANF(3, 4);
void xen_device_set_max_grant_refs(XenDevice *xendev, unsigned int nr_refs,
Error **errp);
--
2.38.1
- [PATCH 0/6] enforce use of G_GNUC_PRINTF annotations, Daniel P . Berrangé, 2022/12/19
- [PATCH 6/6] enforce use of G_GNUC_PRINTF attributes, Daniel P . Berrangé, 2022/12/19
- [PATCH 3/6] tools/virtiofsd: add G_GNUC_PRINTF for logging functions, Daniel P . Berrangé, 2022/12/19
- [PATCH 1/6] disas: add G_GNUC_PRINTF to gstring_printf, Daniel P . Berrangé, 2022/12/19
- [PATCH 4/6] util/error: add G_GNUC_PRINTF for various functions, Daniel P . Berrangé, 2022/12/19
- [PATCH 5/6] tests: add G_GNUC_PRINTF for various functions, Daniel P . Berrangé, 2022/12/19
- [PATCH 2/6] hw/xen: use G_GNUC_PRINTF/SCANF for various functions,
Daniel P . Berrangé <=
- Re: [PATCH 0/6] enforce use of G_GNUC_PRINTF annotations, Paolo Bonzini, 2022/12/22