[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/5] iotests: make meson aware of individual I/O tests
From: |
Daniel P . Berrangé |
Subject: |
Re: [PATCH 0/5] iotests: make meson aware of individual I/O tests |
Date: |
Thu, 2 Mar 2023 18:54:38 +0000 |
User-agent: |
Mutt/2.2.9 (2022-11-12) |
On Thu, Mar 02, 2023 at 06:46:01PM +0000, Daniel P. Berrangé wrote:
> To just repeat the patch 5 description...
>
> Currently meson registers a single test that invokes an entire group of
> I/O tests, hiding the test granularity from meson. There are various
> downsides of doing this
>
> * You cannot ask 'meson test' to invoke a single I/O test
> * The meson test timeout can't be applied to the individual
> tests
> * Meson only gets a pass/fail for the overall I/O test group
> not individual tests
Another big benefit is that we get to see the execution time of
every I/O test, so can identify which handful of tests are making
it take almost 5 minutes to run in gitlab...
The really big 4 are:
199/314 qemu:block / qemu-iotests-qcow2-040 OK 16.62s 1 subtests passed
200/314 qemu:block / qemu-iotests-qcow2-041 OK 44.51s 1 subtests passed
265/314 qemu:block / qemu-iotests-qcow2-191 OK 17.93s 1 subtests passed
282/314 qemu:block / qemu-iotests-qcow2-271 OK 25.03s 1 subtests passed
there are a bunch in the ~5 second range, and then most are
1 second or less.
> * If a CI job gets killed by the GitLab timeout, we don't
> get visibility into how far through the I/O tests
> execution got.
>
> This is not really specific to the I/O tests, the problem is common
> to any case of us running a test which is in fact another test
> harness which runs many tests. It would be nice to have meson have
> the full view of all tests run. Adapting the I/O tests is as easy
> win in this respect.
>
> This switches meson to perform test discovery by invoking 'check' in
> dry-run mode. It then registers one meson test case for each I/O
> test. Parallel execution remains disabled since the I/O tests do not
> use self contained execution environments and thus conflict with
> each other.
>
> Compare contrast output from a current job:
>
> https://gitlab.com/qemu-project/qemu/-/jobs/3863603546
>
> [quote]
> 204/224 qemu:block / qemu-iotests qcow2 OK 329.94s 119 subtests passed
> [/quote]
>
> Vs what is seen with this series:
>
> https://gitlab.com/berrange/qemu/-/jobs/3865975463
>
> [quote]
> 204/350 qemu:block / qemu-iotests-qcow2-001 OK 2.16s 1 subtests passed
> 205/350 qemu:block / qemu-iotests-qcow2-002 OK 2.77s 1 subtests passed
>
> ...snip...
>
> 329/350 qemu:block / qemu-iotests-qcow2-qemu-img-close-errors OK
> 6.19s 1 subtests passed
> 330/350 qemu:block / qemu-iotests-qcow2-qsd-jobs OK 0.55s 1
> subtests passed
> [/quote]
>
> A few tweaks were needed to the iotests runner because it had a few
> assumptions about it always running in a tree that has already been
> built, which is obviously not the case at the time meson does test
> discovery.
>
> Daniel P. Berrangé (5):
> iotests: explicitly pass source/build dir to 'check' command
> iotests: allow test discovery before building
> iotests: strip subdir path when listing tests
> iotests: print TAP protocol version when reporting tests
> iotests: register each I/O test separately with meson
>
> tests/qemu-iotests/check | 11 +++++++++--
> tests/qemu-iotests/meson.build | 33 ++++++++++++++++++++++++++------
> tests/qemu-iotests/testenv.py | 22 +++++++++++++++++----
> tests/qemu-iotests/testrunner.py | 1 +
> 4 files changed, 55 insertions(+), 12 deletions(-)
>
> --
> 2.39.2
>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- Re: [PATCH 2/5] iotests: allow test discovery before building, (continued)