Re: [PATCH 0/3] block: remove separate bdrv_file_open callback

[Philippe Mathieu-Daudé]

On 9/3/23 09:50, Paolo Bonzini wrote:
> The value of the bdrv_file_open is sometimes checked to distinguish
> protocol and format drivers, but apart from that there is no difference
> between bdrv_file_open and bdrv_open.
>
> However, they can all be distinguished by the non-NULL .protocol_name
> member.  Change the checks to use .protocol_name instead of .bdrv_file_open,
> and unify the two callbacks.

Nice cleanup. Series:

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

> Paolo Bonzini (3):
>    block: make assertion more generic
>    block: do not check bdrv_file_open
>    block: remove separate bdrv_file_open callback