Re: [PATCH v2] block: replace TABs with space

[Eric Blake]

On Fri, Mar 10, 2023 at 11:19:05AM +0800, Yeqi Fu wrote:
> Bring the block files in line with the QEMU coding style, with spaces
> for indentation.
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/371

In v1, I mentioned I like (but don't insist on) one-space '='; then
Kevin mentioned he likes aligned '=', although I can see how his
comment may have landed after you had already started editing per my
review.  Note that we do not have a documented rule for which style
should be used.  After reading through your patch, I see v2 went the
route of uniformly using one-space '=', which causes more (one-time)
churn in some files than others.  It may be worth specifically
mentioning this as part of your commit message, especially since it
was a point brought up during review and since not everyone favors
that style.

Maybe I should have also stated earlier: when writing bulk patches, I
try to be conservative on reformatting: while project-wide consistency
is nice, I'm more worried about per-file consistency.  If a single
file has an inconsistent mix between one-space '=' and aligned '=', or
if the alignment has broken, I don't mind fixing that file to look
nicer; however, my fix may tend to move the minority formatted lines
to match the majority, rather than towards any global style.  But if a
file already has what appears to be self-consistent formatting, even
if it is unlike other files, I try to preserve that style.

But what I don't want is to delay your patch on a style argument -
it's not fair for me to hold up your work on something that does not
affect runtime correctness.  So that said, since I'm not the main
block maintainer, you are probably better off waiting for Kevin's
verdict (if he really wants aligned '=' in block files, that's worth a
v3; but if he is okay living with code that doesn't meet his personal
style, then v2 is good enough).

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org