[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [COMMIT 7169cb6] suport device driver initialization mode

From: Anthony Liguori
Subject: [Qemu-commits] [COMMIT 7169cb6] suport device driver initialization model
Date: Fri, 01 May 2009 15:05:18 -0000

From: Glauber Costa <address@hidden>

According to PnP specification, Appendix B, Option ROMs
that support DDIM (device driver initialization model) should
have their memory space writeable.

KVM deviates from us here, by removing the IO_MEM_ROM flag,
to allow for PCI option ROMs (they require DDIM). However,
there's absolutely no reason we can't do the same.

Signed-off-by: Glauber Costa <address@hidden>
Signed-off-by: Anthony Liguori <address@hidden>

diff --git a/hw/pc.c b/hw/pc.c
index 340b313..61f6e7b 100644
--- a/hw/pc.c
+++ b/hw/pc.c
@@ -920,8 +920,7 @@ static void pc_init1(ram_addr_t ram_size, int vga_ram_size,
     option_rom_offset = qemu_ram_alloc(0x20000);
     oprom_area_size = 0;
-    cpu_register_physical_memory(0xc0000, 0x20000,
-                                 option_rom_offset | IO_MEM_ROM);
+    cpu_register_physical_memory(0xc0000, 0x20000, option_rom_offset);
     if (using_vga) {
         /* VGA BIOS load */

reply via email to

[Prev in Thread] Current Thread [Next in Thread]