[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [COMMIT 2eed5a0] e1000: Do not reinit pci config space to

From: Anthony Liguori
Subject: [Qemu-commits] [COMMIT 2eed5a0] e1000: Do not reinit pci config space to 0
Date: Fri, 08 May 2009 20:53:34 -0000

From: Amit Shah <address@hidden>

pci_register_device already mallocs the pci config space buffer filled
with zeroes.

Doing this again breaks some default config space writes like
setting the subsystem vendor id and subsystem device id.

Signed-off-by: Amit Shah <address@hidden>
Signed-off-by: Anthony Liguori <address@hidden>

diff --git a/hw/e1000.c b/hw/e1000.c
index b0fe917..940e893 100644
--- a/hw/e1000.c
+++ b/hw/e1000.c
@@ -1067,7 +1067,6 @@ pci_e1000_init(PCIBus *bus, NICInfo *nd, int devfn)
        return NULL;
     pci_conf = d->dev.config;
-    memset(pci_conf, 0, 256);
     pci_config_set_vendor_id(pci_conf, PCI_VENDOR_ID_INTEL);
     pci_config_set_device_id(pci_conf, E1000_DEVID);

reply via email to

[Prev in Thread] Current Thread [Next in Thread]