[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [COMMIT 9075000] Fix detached migration with exec.

From: Anthony Liguori
Subject: [Qemu-commits] [COMMIT 9075000] Fix detached migration with exec.
Date: Thu, 27 Aug 2009 22:03:58 -0000

From: Chris Lalancette <address@hidden>

When trying to do detached migration with exec, I found that
the monitor wouldn't always return in a timely manner.  I
tracked this down to exec_start_outgoing_migration.  It
appeared we were setting the fd to NONBLOCK'ing, but in
point of fact we weren't.

This bugfix should also go onto the stable 0.10 branch

Signed-off-by: Chris Lalancette <address@hidden>
Signed-off-by: Anthony Liguori <address@hidden>

diff --git a/migration-exec.c b/migration-exec.c
index e3616be..ef4620f 100644
--- a/migration-exec.c
+++ b/migration-exec.c
@@ -73,10 +73,7 @@ MigrationState *exec_start_outgoing_migration(const char 
         goto err_after_open;
-    if (fcntl(s->fd, F_SETFD, O_NONBLOCK) == -1) {
-        dprintf("Unable to set nonblocking mode on file descriptor\n");
-        goto err_after_open;
-    }
+    socket_set_nonblock(s->fd);
     s->opaque = qemu_popen(f, "w");

reply via email to

[Prev in Thread] Current Thread [Next in Thread]