[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [COMMIT 9e3a95e] Fix compiler warnings

From: Anthony Liguori
Subject: [Qemu-commits] [COMMIT 9e3a95e] Fix compiler warnings
Date: Mon, 31 Aug 2009 15:48:05 -0000

From: Stefan Weil <address@hidden>

Starting with commit df7a86ed735eafefbd046c8cad7134652fe3f600,
mingw32 builds result in a compiler warning for dns_addr:

  CC    slirp/slirp.o
/home/stefan/src/qemu/savannah/qemu/slirp/slirp.c:50: warning: missing braces 
around initializer
/home/stefan/src/qemu/savannah/qemu/slirp/slirp.c:50: warning: (near 
initialization for ‘dns_addr.S_un’)

Removing the assignment fixes the warning without the need of special code
for mingw32 (and also saves some bytes in the resulting binary).

To fix another potential compiler warning, the missing 'static'
attribute was added.

The same changes were applied to dns_addr_time.

Signed-off-by: Stefan Weil <address@hidden>
Signed-off-by: Blue Swirl <address@hidden>

diff --git a/slirp/slirp.c b/slirp/slirp.c
index b5335a5..691420e 100644
--- a/slirp/slirp.c
+++ b/slirp/slirp.c
@@ -47,8 +47,8 @@ static int do_slowtimo;
 static TAILQ_HEAD(slirp_instances, Slirp) slirp_instances =
-struct in_addr dns_addr = { 0 };
-u_int dns_addr_time = 0;
+static struct in_addr dns_addr;
+static u_int dns_addr_time;
 #ifdef _WIN32

reply via email to

[Prev in Thread] Current Thread [Next in Thread]