[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [COMMIT 675ebef] monitor: fail when 'i' type is greater t

From: Anthony Liguori
Subject: [Qemu-commits] [COMMIT 675ebef] monitor: fail when 'i' type is greater than 32-bit
Date: Fri, 04 Sep 2009 14:44:05 -0000

From: Luiz Capitulino <address@hidden>

The 'i' argument type is for 32-bit only and most handlers
will use an 'int' to store its value.

It's better to fail gracefully when the user enters a value
greater than 32-bit than to get subtle casting bugs.

Signed-off-by: Luiz Capitulino <address@hidden>
Signed-off-by: Anthony Liguori <address@hidden>

diff --git a/monitor.c b/monitor.c
index 9067bf0..5322bc8 100644
--- a/monitor.c
+++ b/monitor.c
@@ -2759,6 +2759,12 @@ static const mon_cmd_t *monitor_parse_command(Monitor 
                 if (get_expr(mon, &val, &p))
                     goto fail;
+                /* Check if 'i' is greater than 32-bit */
+                if ((c == 'i') && ((val >> 32) & 0xffffffff)) {
+                    monitor_printf(mon, "\'%s\' has failed: ", cmdname);
+                    monitor_printf(mon, "integer is for 32-bit values\n");
+                    goto fail;
+                }
                 qdict_put(qdict, key, qint_from_int(val));

reply via email to

[Prev in Thread] Current Thread [Next in Thread]