[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [COMMIT 4e2f73c] do not issue ioctl from within the io th

From: Anthony Liguori
Subject: [Qemu-commits] [COMMIT 4e2f73c] do not issue ioctl from within the io thread
Date: Fri, 04 Sep 2009 14:43:55 -0000

From: Glauber Costa <address@hidden>

According to Documentation/kvm/api.txt, (and well, to common sense),
we should not be calling vcpu ioctls from within the iothread.
Since vcpu initialization issues a vcpu ioctl, move it a little bit
further in time to prevent it.

Signed-off-by: Glauber Costa <address@hidden>
Signed-off-by: Anthony Liguori <address@hidden>

diff --git a/vl.c b/vl.c
index 4f75d9b..dd5eebf 100644
--- a/vl.c
+++ b/vl.c
@@ -3749,6 +3749,7 @@ static void *kvm_cpu_thread_fn(void *arg)
+    kvm_init_vcpu(env);
     /* signal CPU creation */
@@ -3944,7 +3945,6 @@ static void tcg_init_vcpu(void *_env)
 static void kvm_start_vcpu(CPUState *env)
-    kvm_init_vcpu(env);
     env->thread = qemu_mallocz(sizeof(QemuThread));
     env->halt_cond = qemu_mallocz(sizeof(QemuCond));

reply via email to

[Prev in Thread] Current Thread [Next in Thread]