[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [COMMIT 13f5545] Fix VMSTATE_PCI_DEVICE version

From: Anthony Liguori
Subject: [Qemu-commits] [COMMIT 13f5545] Fix VMSTATE_PCI_DEVICE version
Date: Wed, 09 Sep 2009 23:27:13 -0000

From: Juan Quintela <address@hidden>

PCI device entries have to have a default version, not 2, because they are
used in the midle of other structures that can have _any_ version number.

We can't use proper versioning here until we have SubSections support.
Why we didn't noticed before?  Because in a PC, the only device ported with
a version less that 2 is piix_pm, and for that one, default pci values are
right.  If you use a virtio-console, you will see that its state it is not
loaded back.

Thanks to Amit Shah for reporting the problem and help debug the fix.

Signed-off-by: Juan Quintela <address@hidden>
Signed-off-by: Anthony Liguori <address@hidden>

diff --git a/hw/hw.h b/hw/hw.h
index 0ae4000..a0cb94e 100644
--- a/hw/hw.h
+++ b/hw/hw.h
@@ -408,7 +408,6 @@ extern const VMStateDescription vmstate_pci_device;
 #define VMSTATE_PCI_DEVICE(_field, _state) {                         \
     .name       = (stringify(_field)),                               \
-    .version_id = 2,                                                 \
     .size       = sizeof(PCIDevice),                                 \
     .vmsd       = &vmstate_pci_device,                               \
     .flags      = VMS_STRUCT,                                        \

reply via email to

[Prev in Thread] Current Thread [Next in Thread]