[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [COMMIT 02c068c] Fix and improve qint_from_int64_test

From: Anthony Liguori
Subject: [Qemu-commits] [COMMIT 02c068c] Fix and improve qint_from_int64_test
Date: Sat, 26 Sep 2009 19:31:56 -0000

From: Pierre Riteau <address@hidden>

Use a long long integer constant to fix a compilation error (integer
constant is too large for 'long' type).

Use a better value for testing, as -1 makes the test pass even if
qi->value is of type uint32_t, float or double. This was suggested by
Reimar Döffinger <address@hidden>.

Also, make the test fail when qi->value is of type double or float by
casting qi->value to int64_t, to avoid value being promoted to the type
of qi->value.

Signed-off-by: Pierre Riteau <address@hidden>
Acked-by: Luiz Capitulino <address@hidden>
Signed-off-by: Aurelien Jarno <address@hidden>

diff --git a/check-qint.c b/check-qint.c
index ae5d22f..49887bb 100644
--- a/check-qint.c
+++ b/check-qint.c
@@ -43,10 +43,10 @@ END_TEST
     QInt *qi;
-    const int64_t value = 0xffffffffffffffff;
+    const int64_t value = 0x1234567890abcdefLL;
     qi = qint_from_int(value);
-    fail_unless(qi->value == value);
+    fail_unless((int64_t) qi->value == value);

reply via email to

[Prev in Thread] Current Thread [Next in Thread]