[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [COMMIT 2e87c5b] musicpal: Catch null TX qeueues

From: Anthony Liguori
Subject: [Qemu-commits] [COMMIT 2e87c5b] musicpal: Catch null TX qeueues
Date: Mon, 05 Oct 2009 14:53:17 -0000

From: Jan Kiszka <address@hidden>

They likely represent invalid queues that should be skipped. We already
do this for RX queues. Wish I had a spec...

Credits go to malc for analyzing the issue and suggesting this fix.

Signed-off-by: Jan Kiszka <address@hidden>
Signed-off-by: Anthony Liguori <address@hidden>

diff --git a/hw/musicpal.c b/hw/musicpal.c
index 1c4f17c..c8f0235 100644
--- a/hw/musicpal.c
+++ b/hw/musicpal.c
@@ -238,7 +238,9 @@ static void eth_send(mv88w8618_eth_state *s, int 
     uint8_t buf[2048];
     int len;
+    if (!desc_addr) {
+        return;
+    }
     do {
         eth_tx_desc_get(desc_addr, &desc);
         if (desc.cmdstat & MP_ETH_TX_OWN) {

reply via email to

[Prev in Thread] Current Thread [Next in Thread]