[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [COMMIT e5bc201] do proper cpu_self check

From: Anthony Liguori
Subject: [Qemu-commits] [COMMIT e5bc201] do proper cpu_self check
Date: Mon, 05 Oct 2009 14:53:19 -0000

From: Glauber Costa <address@hidden>

Currently, our check for qemu_cpu_self only checks if there is a cpu
currently in execution (represented by cpu_single_env being set). While
this might be okay for tcg, it is certainly not okay for kvm, since multiple
cpus might be executing.

Instead, I propose we use pthread primitives to test if the caller thread is
the same as env->thread.

For tcg, it will have the same semantics as before, since all CPUStates will
point to the same thread, and we'll only have one in execution at a time.

Signed-off-by: Glauber Costa <address@hidden>
Signed-off-by: Anthony Liguori <address@hidden>

diff --git a/vl.c b/vl.c
index 4d9db01..19e11b2 100644
--- a/vl.c
+++ b/vl.c
@@ -3591,9 +3591,14 @@ void qemu_cpu_kick(void *_env)
         qemu_thread_signal(env->thread, SIGUSR1);
-int qemu_cpu_self(void *env)
+int qemu_cpu_self(void *_env)
-    return (cpu_single_env != NULL);
+    CPUState *env = _env;
+    QemuThread this;
+    qemu_thread_self(&this);
+    return qemu_thread_equal(&this, env->thread);
 static void cpu_signal(int sig)

reply via email to

[Prev in Thread] Current Thread [Next in Thread]