[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [COMMIT 48042d8] Fix pci_vga_init() not to ignore bus arg

From: Anthony Liguori
Subject: [Qemu-commits] [COMMIT 48042d8] Fix pci_vga_init() not to ignore bus argument
Date: Mon, 05 Oct 2009 14:53:35 -0000

From: Markus Armbruster <address@hidden>

Commit a414c306 converted all VGA devices to qdev.  It used
pci_create_simple() for all devices, except for this one it used
pci_create().  That's wrong, because it uses PCI bus#0 regardless of
the bus argument.  Fix by switching to pci_create_noinit().

Signed-off-by: Markus Armbruster <address@hidden>
Signed-off-by: Anthony Liguori <address@hidden>

diff --git a/hw/vga-pci.c b/hw/vga-pci.c
index ccc78e5..17b3732 100644
--- a/hw/vga-pci.c
+++ b/hw/vga-pci.c
@@ -125,7 +125,7 @@ int pci_vga_init(PCIBus *bus,
     PCIDevice *dev;
-    dev = pci_create("VGA", NULL);
+    dev = pci_create_noinit(bus, -1, "VGA");
     qdev_prop_set_uint32(&dev->qdev, "bios-offset", vga_bios_offset);
     qdev_prop_set_uint32(&dev->qdev, "bios-size", vga_bios_offset);

reply via email to

[Prev in Thread] Current Thread [Next in Thread]