[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [COMMIT 0148fde] Fix exit on 'pci_add' Monitor command

From: Anthony Liguori
Subject: [Qemu-commits] [COMMIT 0148fde] Fix exit on 'pci_add' Monitor command
Date: Mon, 05 Oct 2009 14:53:20 -0000

From: Luiz Capitulino <address@hidden>

If the user issues one of the following commands to the Monitor:

pci_add pci_addr=auto nic model=None
pci_add pci_addr=auto nic model=?

QEMU will exit, because the function used to perform sanity
checks (qemu_check_nic_model_list()) exits on error.

This function is used by the startup code, where it makes
sense to exit on error, but in the Monitor it doesn't.

Changing qemu_check_nic_model_list() to not exit on error
is not possible though, as it's used by the board init
code (the PC one), where all board specific code must have
void return.

The way I've chosen to fix this was to introduce a new function
called pci_nic_supported(), which checks if the NIC is supported
and returns true or false accordingly.

The new function is used only by the Monitor, it performs the
necessary check and returns an error in case the NIC is not
supported, thus qemu_check_nic_model_list()'s exit is never trigged.

The following should be observed:

1. Only the specified NIC is checked, the default one is assumed
to be supported

2. The NIC query command (model=?) won't work with pci_add, the
right way to do this with the Monitor is to add a new command

Signed-off-by: Luiz Capitulino <address@hidden>
Signed-off-by: Anthony Liguori <address@hidden>

diff --git a/hw/pci-hotplug.c b/hw/pci-hotplug.c
index f3dc421..89974a0 100644
--- a/hw/pci-hotplug.c
+++ b/hw/pci-hotplug.c
@@ -46,6 +46,10 @@ static PCIDevice *qemu_pci_hot_add_nic(Monitor *mon,
         monitor_printf(mon, "Parameter addr not supported\n");
         return NULL;
+    if (nd_table[ret].model && !pci_nic_supported(nd_table[ret].model))
+        return NULL;
     return pci_nic_init(&nd_table[ret], "rtl8139", devaddr);
diff --git a/hw/pci.c b/hw/pci.c
index c46410a..c656bd0 100644
--- a/hw/pci.c
+++ b/hw/pci.c
@@ -806,6 +806,17 @@ static const char * const pci_nic_names[] = {
+int pci_nic_supported(const char *model)
+    int i;
+    for (i = 0; pci_nic_names[i]; i++)
+        if (strcmp(model, pci_nic_names[i]) == 0)
+            return 1;
+    return 0;
 /* Initialize a PCI NIC.  */
 PCIDevice *pci_nic_init(NICInfo *nd, const char *default_model,
                         const char *default_devaddr)
diff --git a/hw/pci.h b/hw/pci.h
index caba5c8..ba748ff 100644
--- a/hw/pci.h
+++ b/hw/pci.h
@@ -252,6 +252,7 @@ PCIBus *pci_register_bus(DeviceState *parent, const char 
                          pci_set_irq_fn set_irq, pci_map_irq_fn map_irq,
                          void *irq_opaque, int devfn_min, int nirq);
+int pci_nic_supported(const char *model);
 PCIDevice *pci_nic_init(NICInfo *nd, const char *default_model,
                         const char *default_devaddr);
 void pci_data_write(void *opaque, uint32_t addr, uint32_t val, int len);

reply via email to

[Prev in Thread] Current Thread [Next in Thread]