[Qemu-commits] [qemu/qemu] fa779b: Add support for pretty-printing respo

qemu-commits
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-commits] [qemu/qemu] fa779b: Add support for pretty-printing respo

From:	GitHub
Subject:	[Qemu-commits] [qemu/qemu] fa779b: Add support for pretty-printing response in qmp-sh...
Date:	Mon, 10 Sep 2012 06:30:14 -0700
  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: fa779b65fa77d5632df1f8b2df33e9023dbc4cc8
      
https://github.com/qemu/qemu/commit/fa779b65fa77d5632df1f8b2df33e9023dbc4cc8
  Author: Daniel P. Berrange <address@hidden>
  Date:   2012-09-05 (Wed, 05 Sep 2012)

  Changed paths:
    M QMP/qmp-shell

  Log Message:
  -----------
  Add support for pretty-printing response in qmp-shell

Add a '-p' arg to the QMP/qmp-shell test program, which uses
the python pprint module to pretty-print the dictionary
returned from a command

  $ qmp-shell -p /tmp/qemu
  Welcome to the QMP low-level shell!
  Connected to QEMU 1.1.50

  (QEMU) query-cpus
  {   u'return': [   {   u'CPU': 0,
                   u'current': True,
                   u'halted': True,
                   u'pc': 1048556,
                   u'thread_id': 7108}]}

Signed-off-by: Daniel P. Berrange <address@hidden>
Signed-off-by: Luiz Capitulino <address@hidden>


  Commit: 886cc706ce5d4d3d1c296f028ddc2991cfbe3bbe
      
https://github.com/qemu/qemu/commit/886cc706ce5d4d3d1c296f028ddc2991cfbe3bbe
  Author: Amos Kong <address@hidden>
  Date:   2012-09-05 (Wed, 05 Sep 2012)

  Changed paths:
    M hmp-commands.hx

  Log Message:
  -----------
  fix doc of using raw values with sendkey

(qemu) sendkey a
(qemu) sendkey 0x1e
(qemu) sendkey #0x1e
 unknown key: '#0x1e'

The last command doesn't work, '#' is not requested before
raw values, and the raw value in decimal format is not supported.

Signed-off-by: Amos Kong <address@hidden>
Signed-off-by: Luiz Capitulino <address@hidden>


  Commit: cd383492bfb5ea805d518e129d7a5402c7b99ef2
      
https://github.com/qemu/qemu/commit/cd383492bfb5ea805d518e129d7a5402c7b99ef2
  Author: Amos Kong <address@hidden>
  Date:   2012-09-05 (Wed, 05 Sep 2012)

  Changed paths:
    M monitor.c

  Log Message:
  -----------
  monitor: rename keyname '<' to 'less'

There are many maps of keycode 0x56 in pc-bios/keymaps/*
  pc-bios/keymaps/common:less 0x56
  pc-bios/keymaps/common:greater 0x56 shift
  pc-bios/keymaps/common:bar 0x56 altgr
  pc-bios/keymaps/common:brokenbar 0x56 shift altgr

This patch just renamed '<' to 'less', QAPI might add new
variable by adding a prefix to keyname, '$PREFIX_<' is not
available, '$PREFIX_less' is ok.

For compatibility, convert user inputted '<' to 'less'.

Signed-off-by: Amos Kong <address@hidden>
Signed-off-by: Luiz Capitulino <address@hidden>


  Commit: 2ef20c15b4736c9b0afc7ef2b14239182fbcd3e1
      
https://github.com/qemu/qemu/commit/2ef20c15b4736c9b0afc7ef2b14239182fbcd3e1
  Author: Amos Kong <address@hidden>
  Date:   2012-09-05 (Wed, 05 Sep 2012)

  Changed paths:
    M hmp-commands.hx
    M monitor.c

  Log Message:
  -----------
  hmp: rename arguments

Rename 'string' to 'keys', rename 'hold_time' to 'hold-time'.

Signed-off-by: Amos Kong <address@hidden>
Signed-off-by: Luiz Capitulino <address@hidden>


  Commit: b9c4b48d50057b6aee7c70879b240ff76f39c85b
      
https://github.com/qemu/qemu/commit/b9c4b48d50057b6aee7c70879b240ff76f39c85b
  Author: Amos Kong <address@hidden>
  Date:   2012-09-05 (Wed, 05 Sep 2012)

  Changed paths:
    M scripts/qapi-types.py
    M scripts/qapi-visit.py

  Log Message:
  -----------
  qapi: generate list struct and visit_list for enum

Currently, if we define an 'enum' and use it in one command's
data, list struct for enum could not be generated, but it's
used in qmp function.

For example: KeyCodesList could not be generated.
>>> qapi-schema.json:
{ 'enum': 'KeyCodes',
  'data': [ 'shift', 'alt' ... ] }
{ 'command': 'sendkey',
  'data': { 'keys': ['KeyCodes'], '*hold-time': 'int' } }

>>> qmp-command.h:
void qmp_sendkey(KeyCodesList * keys, bool has_hold_time, int64_t
hold_time, Error **errp);

This patch lets qapi generate list struct and visit_list for enum.

Signed-off-by: Amos Kong <address@hidden>
Signed-off-by: Luiz Capitulino <address@hidden>


  Commit: 411656f48d71131d6d1cb5b6db792fc7b451e72e
      
https://github.com/qemu/qemu/commit/411656f48d71131d6d1cb5b6db792fc7b451e72e
  Author: Amos Kong <address@hidden>
  Date:   2012-09-05 (Wed, 05 Sep 2012)

  Changed paths:
    M qapi-schema.json

  Log Message:
  -----------
  qapi: add the QKeyCode enum

key_defs[] in monitor.c is a mapping table of keys and keycodes,
this patch added a QKeyCode enum. Key's index in the enmu is same
as keycode's index in key_defs[].

Signed-off-by: Amos Kong <address@hidden>
Signed-off-by: Luiz Capitulino <address@hidden>


  Commit: 1048c88f03545fa42bdebb077871a743a614d2ab
      
https://github.com/qemu/qemu/commit/1048c88f03545fa42bdebb077871a743a614d2ab
  Author: Amos Kong <address@hidden>
  Date:   2012-09-05 (Wed, 05 Sep 2012)

  Changed paths:
    M console.h
    M input.c
    M monitor.c

  Log Message:
  -----------
  monitor: move key_defs[] table and introduce two help functions

This patch added two help functions to convert key/code to index of
mapping table, those functions will return Q_KEY_CODE_MAX if the
code/key is invalid.

Patch also moved key_defs[] to input.c, and removed useless KeyDef struct.
Key's index in QKeyCode enmu is same as keycode's index in new key_defs[].
Monitor functions were changed to access key_defs[] directly.

key_defs[] is used in do_send_key(), so export key_defs[]. It will be
changed to static in next patch.

Signed-off-by: Amos Kong <address@hidden>
Signed-off-by: Luiz Capitulino <address@hidden>


  Commit: e4c8f004c55d9da3eae3e14df740238bf805b5d6
      
https://github.com/qemu/qemu/commit/e4c8f004c55d9da3eae3e14df740238bf805b5d6
  Author: Amos Kong <address@hidden>
  Date:   2012-09-05 (Wed, 05 Sep 2012)

  Changed paths:
    M console.h
    M hmp-commands.hx
    M hmp.c
    M hmp.h
    M input.c
    M monitor.c
    M qapi-schema.json
    M qmp-commands.hx

  Log Message:
  -----------
  qapi: convert sendkey

Convert 'sendkey' to use QAPI.

QAPI passes key's index of mapping table to qmp_send_key(),
not keycode. So we use help functions to convert key/code to
index of key_defs, and 'index' will be converted to 'keycode'
inside qmp_send_key().

For qmp, QAPI would check invalid key and raise error.
For hmp, invalid key is checked in hmp_send_key().

'send-key' of QMP doesn't support key in hexadecimal format.

Signed-off-by: Amos Kong <address@hidden>
Signed-off-by: Luiz Capitulino <address@hidden>


  Commit: 227ccf6bff234c29974c2c18ecd3a29e6b965e3d
      
https://github.com/qemu/qemu/commit/227ccf6bff234c29974c2c18ecd3a29e6b965e3d
  Author: Stefan Weil <address@hidden>
  Date:   2012-09-05 (Wed, 05 Sep 2012)

  Changed paths:
    M scripts/qapi-visit.py

  Log Message:
  -----------
  qapi: Fix potential NULL pointer segfault

Report from smatch:

qapi-visit.c:1640 visit_type_BlockdevAction(8) error:
 we previously assumed 'obj' could be null (see line 1639)
qapi-visit.c:2432 visit_type_NetClientOptions(8) error:
 we previously assumed 'obj' could be null (see line 2431)

Signed-off-by: Stefan Weil <address@hidden>
Reviewed-by: Paolo Bonzini <address@hidden>
Signed-off-by: Luiz Capitulino <address@hidden>


  Commit: 149474c93490e1c66f838391bd491db83136d91d
      
https://github.com/qemu/qemu/commit/149474c93490e1c66f838391bd491db83136d91d
  Author: Stefan Weil <address@hidden>
  Date:   2012-09-05 (Wed, 05 Sep 2012)

  Changed paths:
    M qobject.h

  Log Message:
  -----------
  json-parser: Fix potential NULL pointer segfault

Report from smatch:
json-parser.c:474 parse_object(62) error: potential null derefence 'dict'.
json-parser.c:553 parse_array(75) error: potential null derefence 'list'.

Label 'out' in json-parser.c can be called with list == NULL
which is passed to QDECREF.

Modify QDECREF to handle a NULL argument (inline function qobject_decref
already handles them, too).

Signed-off-by: Stefan Weil <address@hidden>
Signed-off-by: Luiz Capitulino <address@hidden>


  Commit: 75d789f8d38be693bbee3e77b558e59012e33997
      
https://github.com/qemu/qemu/commit/75d789f8d38be693bbee3e77b558e59012e33997
  Author: Luiz Capitulino <address@hidden>
  Date:   2012-09-05 (Wed, 05 Sep 2012)

  Changed paths:
    M error.h

  Log Message:
  -----------
  error: add error_setg()

Signed-off-by: Luiz Capitulino <address@hidden>


  Commit: d7098135d4baac8141b2e76f2daa8a7f61599c72
      
https://github.com/qemu/qemu/commit/d7098135d4baac8141b2e76f2daa8a7f61599c72
  Author: Luiz Capitulino <address@hidden>
  Date:   2012-09-05 (Wed, 05 Sep 2012)

  Changed paths:
    M console.c
    M console.h
    M hw/blizzard.c
    M hw/g364fb.c
    M hw/omap_lcdc.c
    M hw/qxl.c
    M hw/tcx.c
    M hw/vga.c
    M hw/vmware_vga.c

  Log Message:
  -----------
  console: vga_hw_screen_dump_ptr: take Error argument

All devices that register a screen dump callback via
graphic_console_init() are updated.

The new argument is not used in this commit. Error handling will
be added to each device individually later.

This change is a preparation to convert the screendump command
to the QAPI.

Signed-off-by: Luiz Capitulino <address@hidden>


  Commit: ad39cf6d150e951e4c67c8120d495ae7e78054a6
      
https://github.com/qemu/qemu/commit/ad39cf6d150e951e4c67c8120d495ae7e78054a6
  Author: Luiz Capitulino <address@hidden>
  Date:   2012-09-05 (Wed, 05 Sep 2012)

  Changed paths:
    M console.c
    M console.h
    M hmp-commands.hx
    M hmp.c
    M hmp.h
    M monitor.c
    M qapi-schema.json
    M qmp-commands.hx

  Log Message:
  -----------
  qapi: convert screendump

Next commits will update devices to propagate errors.

Signed-off-by: Luiz Capitulino <address@hidden>


  Commit: d663174dcd9623c44f3af2a46de2a55d16f15c19
      
https://github.com/qemu/qemu/commit/d663174dcd9623c44f3af2a46de2a55d16f15c19
  Author: Luiz Capitulino <address@hidden>
  Date:   2012-09-05 (Wed, 05 Sep 2012)

  Changed paths:
    M hw/blizzard.c
    M hw/qxl.c
    M hw/vga.c
    M hw/vga_int.h
    M hw/vmware_vga.c

  Log Message:
  -----------
  vga: ppm_save(): add error handling

Signed-off-by: Luiz Capitulino <address@hidden>


  Commit: 8dc4cc7bb57d3f0d6a1d8ba372d9eda1494bcc64
      
https://github.com/qemu/qemu/commit/8dc4cc7bb57d3f0d6a1d8ba372d9eda1494bcc64
  Author: Luiz Capitulino <address@hidden>
  Date:   2012-09-05 (Wed, 05 Sep 2012)

  Changed paths:
    M hw/omap_lcdc.c

  Log Message:
  -----------
  omap_lcdc: rename ppm_save() to omap_ppm_save()

Avoids confusion with the global ppm_save() defined in hw/vga.c.

Signed-off-by: Luiz Capitulino <address@hidden>
Reviewed-by: Peter Maydell <address@hidden>


  Commit: d9c7ebb10042a7d29d50b47c110e5cb754293d89
      
https://github.com/qemu/qemu/commit/d9c7ebb10042a7d29d50b47c110e5cb754293d89
  Author: Luiz Capitulino <address@hidden>
  Date:   2012-09-05 (Wed, 05 Sep 2012)

  Changed paths:
    M hw/omap_lcdc.c

  Log Message:
  -----------
  omap_lcdc: omap_ppm_save(): add error handling

Signed-off-by: Luiz Capitulino <address@hidden>


  Commit: 61a3f955c1caca775729fc59e97fb9c97808ffca
      
https://github.com/qemu/qemu/commit/61a3f955c1caca775729fc59e97fb9c97808ffca
  Author: Luiz Capitulino <address@hidden>
  Date:   2012-09-05 (Wed, 05 Sep 2012)

  Changed paths:
    M hw/g364fb.c

  Log Message:
  -----------
  g364fb: g364fb_screen_dump(): add error handling

Signed-off-by: Luiz Capitulino <address@hidden>


  Commit: 537f2d2b0d4c27e21b3e610e57d6511e315d76cc
      
https://github.com/qemu/qemu/commit/537f2d2b0d4c27e21b3e610e57d6511e315d76cc
  Author: Luiz Capitulino <address@hidden>
  Date:   2012-09-05 (Wed, 05 Sep 2012)

  Changed paths:
    M hw/tcx.c

  Log Message:
  -----------
  tcx: tcx24_screen_dump(): add error handling

Signed-off-by: Luiz Capitulino <address@hidden>


  Commit: 0ab6b63655ba59d7c05089017acb721a44979526
      
https://github.com/qemu/qemu/commit/0ab6b63655ba59d7c05089017acb721a44979526
  Author: Luiz Capitulino <address@hidden>
  Date:   2012-09-05 (Wed, 05 Sep 2012)

  Changed paths:
    M hw/tcx.c

  Log Message:
  -----------
  tcx: tcx_screen_dump(): add error handling

Signed-off-by: Luiz Capitulino <address@hidden>


  Commit: 71e470886fb6092504503a5fe41092ace71c096c
      
https://github.com/qemu/qemu/commit/71e470886fb6092504503a5fe41092ace71c096c
  Author: Blue Swirl <address@hidden>
  Date:   2012-09-10 (Mon, 10 Sep 2012)

  Changed paths:
    M target-s390x/helper.c
    M target-s390x/op_helper.c

  Log Message:
  -----------
  target-s390x: fix style

Before splitting op_helper.c and helper.c in the next patches,
fix style issues. No functional changes.

Replace also GCC specific __FUNCTION__ with
standard __func__.

Don't init static variable (cpu_s390x_init:inited) with 0.

Signed-off-by: Blue Swirl <address@hidden>
Signed-off-by: Alexander Graf <address@hidden>


  Commit: e72ca652aa08e3d07c59349f239ba596f27c97af
      
https://github.com/qemu/qemu/commit/e72ca652aa08e3d07c59349f239ba596f27c97af
  Author: Blue Swirl <address@hidden>
  Date:   2012-09-10 (Mon, 10 Sep 2012)

  Changed paths:
    M target-s390x/Makefile.objs
    M target-s390x/cpu.h
    A target-s390x/fpu_helper.c
    M target-s390x/op_helper.c
    M target-s390x/translate.c

  Log Message:
  -----------
  target-s390x: split FPU ops

Move floating point instructions to fpu_helper.c.

While exporting some condition code helpers,
avoid duplicate identifier conflict with translate.c.

Remove unused set_cc_nz_f64() in translate.c.

Signed-off-by: Blue Swirl <address@hidden>
Signed-off-by: Alexander Graf <address@hidden>


  Commit: a78b0504e8d5487fca77b6b0cd8d3c98b9bace8c
      
https://github.com/qemu/qemu/commit/a78b0504e8d5487fca77b6b0cd8d3c98b9bace8c
  Author: Blue Swirl <address@hidden>
  Date:   2012-09-10 (Mon, 10 Sep 2012)

  Changed paths:
    M target-s390x/Makefile.objs
    A target-s390x/cc_helper.c
    M target-s390x/cpu.h
    M target-s390x/op_helper.c

  Log Message:
  -----------
  target-s390x: split condition code helpers

Move condition code helpers to cc_helper.c.

Signed-off-by: Blue Swirl <address@hidden>
Signed-off-by: Alexander Graf <address@hidden>


  Commit: fc8d72c2d34afd6789e8c4374d275a5f69c603f1
      
https://github.com/qemu/qemu/commit/fc8d72c2d34afd6789e8c4374d275a5f69c603f1
  Author: Blue Swirl <address@hidden>
  Date:   2012-09-10 (Mon, 10 Sep 2012)

  Changed paths:
    M target-s390x/Makefile.objs
    A target-s390x/int_helper.c
    M target-s390x/op_helper.c

  Log Message:
  -----------
  target-s390x: split integer helpers

Move integer helpers to int_helper.c.

Signed-off-by: Blue Swirl <address@hidden>
Signed-off-by: Alexander Graf <address@hidden>


  Commit: 8ef7f78e190b3a34e167a31c9a8e43c813c7ff78
      
https://github.com/qemu/qemu/commit/8ef7f78e190b3a34e167a31c9a8e43c813c7ff78
  Author: Blue Swirl <address@hidden>
  Date:   2012-09-10 (Mon, 10 Sep 2012)

  Changed paths:
    M target-s390x/Makefile.objs
    A target-s390x/mem_helper.c
    M target-s390x/op_helper.c

  Log Message:
  -----------
  target-s390x: split memory access helpers

Move memory access helpers to mem_helper.c.

Signed-off-by: Blue Swirl <address@hidden>
[agraf: fold softmmu include ifdefs together]
Signed-off-by: Alexander Graf <address@hidden>


  Commit: aea1e885b2b59cf93d0db9356fd5bb6cb1780f01
      
https://github.com/qemu/qemu/commit/aea1e885b2b59cf93d0db9356fd5bb6cb1780f01
  Author: Blue Swirl <address@hidden>
  Date:   2012-09-10 (Mon, 10 Sep 2012)

  Changed paths:
    M target-s390x/Makefile.objs
    M target-s390x/cpu.h
    A target-s390x/misc_helper.c
    R target-s390x/op_helper.c

  Log Message:
  -----------
  target-s390x: rename op_helper.c to misc_helper.c

Now op_helper.c contains miscellaneous helpers, rename
it to misc_helper.c.

Signed-off-by: Blue Swirl <address@hidden>
[agraf: fix conflict]
Signed-off-by: Alexander Graf <address@hidden>


  Commit: 449c0d70b6d5692bafd8b028e2a8a4e0ed7076fe
      
https://github.com/qemu/qemu/commit/449c0d70b6d5692bafd8b028e2a8a4e0ed7076fe
  Author: Blue Swirl <address@hidden>
  Date:   2012-09-10 (Mon, 10 Sep 2012)

  Changed paths:
    M target-s390x/Makefile.objs
    M target-s390x/cc_helper.c
    M target-s390x/cpu.h
    M target-s390x/fpu_helper.c
    M target-s390x/helper.h
    M target-s390x/mem_helper.c
    M target-s390x/translate.c

  Log Message:
  -----------
  target-s390x: avoid AREG0 for FPU helpers

Make FPU helpers take a parameter for CPUState instead
of relying on global env.

Introduce temporary wrappers for FPU load and store ops.

Signed-off-by: Blue Swirl <address@hidden>
Signed-off-by: Alexander Graf <address@hidden>


  Commit: 4fda26a7b0d6ffbb4055ab8b756cd94647f5fd22
      
https://github.com/qemu/qemu/commit/4fda26a7b0d6ffbb4055ab8b756cd94647f5fd22
  Author: Blue Swirl <address@hidden>
  Date:   2012-09-10 (Mon, 10 Sep 2012)

  Changed paths:
    M target-s390x/Makefile.objs
    M target-s390x/helper.h
    M target-s390x/int_helper.c
    M target-s390x/translate.c

  Log Message:
  -----------
  target-s390x: avoid AREG0 for integer helpers

Make integer helpers take a parameter for CPUState instead
of relying on global env.

Signed-off-by: Blue Swirl <address@hidden>
Signed-off-by: Alexander Graf <address@hidden>


  Commit: 932385a367b2c67f1ea7148dcafb013db188cd23
      
https://github.com/qemu/qemu/commit/932385a367b2c67f1ea7148dcafb013db188cd23
  Author: Blue Swirl <address@hidden>
  Date:   2012-09-10 (Mon, 10 Sep 2012)

  Changed paths:
    M target-s390x/Makefile.objs
    M target-s390x/cc_helper.c
    M target-s390x/helper.h
    M target-s390x/translate.c

  Log Message:
  -----------
  target-s390x: avoid AREG0 for condition code helpers

Make condition code helpers take a parameter for CPUState instead
of relying on global env.

Signed-off-by: Blue Swirl <address@hidden>
Signed-off-by: Alexander Graf <address@hidden>


  Commit: 089f5c06926105a35df461003ae32b7387ed4236
      
https://github.com/qemu/qemu/commit/089f5c06926105a35df461003ae32b7387ed4236
  Author: Blue Swirl <address@hidden>
  Date:   2012-09-10 (Mon, 10 Sep 2012)

  Changed paths:
    M target-s390x/Makefile.objs
    M target-s390x/helper.h
    M target-s390x/mem_helper.c
    M target-s390x/misc_helper.c
    M target-s390x/translate.c

  Log Message:
  -----------
  target-s390x: avoid AREG0 for misc helpers

Make misc helpers take a parameter for CPUState instead
of relying on global env.

Signed-off-by: Blue Swirl <address@hidden>
[agraf: fix conflict]
Signed-off-by: Alexander Graf <address@hidden>


  Commit: 19b0516fb4fd22b08c6ee42ea4162aaf3b9c8ee1
      
https://github.com/qemu/qemu/commit/19b0516fb4fd22b08c6ee42ea4162aaf3b9c8ee1
  Author: Blue Swirl <address@hidden>
  Date:   2012-09-10 (Mon, 10 Sep 2012)

  Changed paths:
    M configure
    M target-s390x/Makefile.objs
    M target-s390x/cpu.h
    M target-s390x/fpu_helper.c
    M target-s390x/helper.c
    M target-s390x/helper.h
    M target-s390x/mem_helper.c
    M target-s390x/misc_helper.c
    M target-s390x/translate.c

  Log Message:
  -----------
  target-s390x: switch to AREG0 free mode

Add an explicit CPUState parameter instead of relying on AREG0.

Remove temporary wrappers and switch to AREG0 free mode.

Signed-off-by: Blue Swirl <address@hidden>
[agraf: fix conflicts]
Signed-off-by: Alexander Graf <address@hidden>


  Commit: 6845df48cec9cc6833429942b3ceed333a791119
      
https://github.com/qemu/qemu/commit/6845df48cec9cc6833429942b3ceed333a791119
  Author: Aurelien Jarno <address@hidden>
  Date:   2012-09-10 (Mon, 10 Sep 2012)

  Changed paths:
    M tcg/s390/tcg-target.c

  Log Message:
  -----------
  tcg/s390: fix ld/st with CONFIG_TCG_PASS_AREG0

The load/store slow path has been broken in e141ab52d:
- We need to move 4 registers for store functions and 3 registers for
  load functions and not the reverse.
- According to the s390x calling convention the arguments of a function
  should be zero extended. This means that the register shift should be
  done with TCG_TYPE_I64 to ensure the higher word is correctly zero
  extended when needed.

I am aware that CONFIG_TCG_PASS_AREG0 is being removed and thus that
this patch can be improved, but doing so means it can also be applied to
the 1.1 and 1.2 stable branches.

Signed-off-by: Aurelien Jarno <address@hidden>
Signed-off-by: Alexander Graf <address@hidden>


  Commit: 149eeb5fe57b853081e8059575d91b8a58a4f96c
      
https://github.com/qemu/qemu/commit/149eeb5fe57b853081e8059575d91b8a58a4f96c
  Author: Stefan Weil <address@hidden>
  Date:   2012-09-10 (Mon, 10 Sep 2012)

  Changed paths:
    M hw/wm8750.c

  Log Message:
  -----------
  hw/wm8750: Fix potential buffer overflow

Report from smatch:

hw/wm8750.c:369 wm8750_tx(12) error: buffer overflow 's->i2c_data' 2 <= 2

It looks like the preprocessor statements were simply misplaced.

Replace also __FUNCTION__ by __func__ to please checkpatch.pl.

Signed-off-by: Stefan Weil <address@hidden>
Reviewed-by: Peter Maydell <address@hidden> 
Signed-off-by: Aurelien Jarno <address@hidden>


  Commit: 599d64f6dc10f267a45e7abebfcafd8e7626585b
      
https://github.com/qemu/qemu/commit/599d64f6dc10f267a45e7abebfcafd8e7626585b
  Author: Stefan Weil <address@hidden>
  Date:   2012-09-10 (Mon, 10 Sep 2012)

  Changed paths:
    M target-arm/helper.c

  Log Message:
  -----------
  target-arm: Fix potential buffer overflow

Report from smatch:

target-arm/helper.c:651 arm946_prbs_read(6) error:
 buffer overflow 'env->cp15.c6_region' 8 <= 8
target-arm/helper.c:661 arm946_prbs_write(6) error:
 buffer overflow 'env->cp15.c6_region' 8 <= 8

c7_region is an array with 8 elements, so the index must be less than 8.

Signed-off-by: Stefan Weil <address@hidden>
Reviewed-by: Peter Maydell <address@hidden>
Signed-off-by: Aurelien Jarno <address@hidden>


  Commit: a32354e206895400d17c3de9a8df1de96d3df289
      
https://github.com/qemu/qemu/commit/a32354e206895400d17c3de9a8df1de96d3df289
  Author: Stefan Weil <address@hidden>
  Date:   2012-09-10 (Mon, 10 Sep 2012)

  Changed paths:
    M hw/mcf5206.c

  Log Message:
  -----------
  hw/mcf5206: Fix buffer overflow for MBAR read / write

Report from smatch:

mcf5206.c:384 m5206_mbar_readb(7) error: buffer overflow 'm5206_mbar_width' 128 
<= 128
mcf5206.c:403 m5206_mbar_readw(8) error: buffer overflow 'm5206_mbar_width' 128 
<= 128
mcf5206.c:427 m5206_mbar_readl(8) error: buffer overflow 'm5206_mbar_width' 128 
<= 128
mcf5206.c:451 m5206_mbar_writeb(9) error: buffer overflow 'm5206_mbar_width' 
128 <= 128
mcf5206.c:475 m5206_mbar_writew(9) error: buffer overflow 'm5206_mbar_width' 
128 <= 128
mcf5206.c:503 m5206_mbar_writel(9) error: buffer overflow 'm5206_mbar_width' 
128 <= 128

m5206_mbar_width has 0x80 elements and supports 0 <= offset < 0x200.

Signed-off-by: Stefan Weil <address@hidden>
Reviewed-by: Peter Maydell <address@hidden>
Signed-off-by: Aurelien Jarno <address@hidden>


  Commit: e22b1e9907833d72f4a959b34c5eefc3533c7711
      
https://github.com/qemu/qemu/commit/e22b1e9907833d72f4a959b34c5eefc3533c7711
  Author: Aurelien Jarno <address@hidden>
  Date:   2012-09-10 (Mon, 10 Sep 2012)

  Changed paths:
    M QMP/qmp-shell
    M console.c
    M console.h
    M error.h
    M hmp-commands.hx
    M hmp.c
    M hmp.h
    M hw/blizzard.c
    M hw/g364fb.c
    M hw/omap_lcdc.c
    M hw/qxl.c
    M hw/tcx.c
    M hw/vga.c
    M hw/vga_int.h
    M hw/vmware_vga.c
    M input.c
    M monitor.c
    M qapi-schema.json
    M qmp-commands.hx
    M qobject.h
    M scripts/qapi-types.py
    M scripts/qapi-visit.py

  Log Message:
  -----------
  Merge branch 'queue/qmp' of git://repo.or.cz/qemu/qmp-unstable

* 'queue/qmp' of git://repo.or.cz/qemu/qmp-unstable:
  tcx: tcx_screen_dump(): add error handling
  tcx: tcx24_screen_dump(): add error handling
  g364fb: g364fb_screen_dump(): add error handling
  omap_lcdc: omap_ppm_save(): add error handling
  omap_lcdc: rename ppm_save() to omap_ppm_save()
  vga: ppm_save(): add error handling
  qapi: convert screendump
  console: vga_hw_screen_dump_ptr: take Error argument
  error: add error_setg()
  json-parser: Fix potential NULL pointer segfault
  qapi: Fix potential NULL pointer segfault
  qapi: convert sendkey
  monitor: move key_defs[] table and introduce two help functions
  qapi: add the QKeyCode enum
  qapi: generate list struct and visit_list for enum
  hmp: rename arguments
  monitor: rename keyname '<' to 'less'
  fix doc of using raw values with sendkey
  Add support for pretty-printing response in qmp-shell


Compare: https://github.com/qemu/qemu/compare/0c267217ca99...e22b1e990783
[Prev in Thread]
Current Thread
[Next in Thread]
[Qemu-commits] [qemu/qemu] fa779b: Add support for pretty-printing response in qmp-sh..., GitHub <=
Prev by Date: [Qemu-commits] [qemu/qemu] 0c2672: musicpal: Fix flash mapping
Next by Date: [Qemu-commits] [qemu/qemu] 835cab: spice: abort on invalid streaming cmdline params
Previous by thread: [Qemu-commits] [qemu/qemu] 0c2672: musicpal: Fix flash mapping
Next by thread: [Qemu-commits] [qemu/qemu] 835cab: spice: abort on invalid streaming cmdline params
Index(es):
- Date
- Thread