[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 7b2d97: util: Fix compilation of envlist.c fo

From: GitHub
Subject: [Qemu-commits] [qemu/qemu] 7b2d97: util: Fix compilation of envlist.c for MinGW
Date: Sun, 03 Feb 2013 08:30:09 -0800

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 7b2d9779818f4c0d4c31d3a0292bee1c4b633217
  Author: Stefan Weil <address@hidden>
  Date:   2013-02-02 (Sat, 02 Feb 2013)

  Changed paths:
    M include/sysemu/os-win32.h
    M util/envlist.c

  Log Message:
  util: Fix compilation of envlist.c for MinGW

MinGW has no strtok_r, so we need a declaration in sysemu/os-win32.h.
We must also fix the include statements in util/envlist.c to include
that file.

We currently don't need an implementation of strtok_r because the
code is compiled but not linked for MinGW.

Signed-off-by: Stefan Weil <address@hidden>
Signed-off-by: Blue Swirl <address@hidden>

  Commit: fbeadf50f2f965741def823036b086bbc2999b1f
  Author: Paolo Bonzini <address@hidden>
  Date:   2013-02-02 (Sat, 02 Feb 2013)

  Changed paths:
    M include/qemu/bitops.h
    M include/qemu/hbitmap.h
    M include/qemu/host-utils.h
    M memory.c
    M util/bitops.c
    M util/hbitmap.c

  Log Message:
  bitops: unify bitops_ffsl with the one in host-utils.h, call it bitops_ctzl

We had two copies of a ffs function for longs with subtly different
semantics and, for the one in bitops.h, a confusing name: the result
was off-by-one compared to the library function ffsl.

Unify the functions into one, and solve the name problem by calling
the 0-based functions "bitops_ctzl" and "bitops_ctol" respectively.

This also fixes the build on platforms with ffsl, including Mac OS X
and Windows.

Signed-off-by: Paolo Bonzini <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Tested-by: Andreas Färber <address@hidden>
Tested-by: Peter Maydell <address@hidden>
Signed-off-by: Blue Swirl <address@hidden>

Compare: https://github.com/qemu/qemu/compare/abd8d4a4d6df...fbeadf50f2f9

reply via email to

[Prev in Thread] Current Thread [Next in Thread]