qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 685cbd: xhci: fix bad print specifier


From: GitHub
Subject: [Qemu-commits] [qemu/qemu] 685cbd: xhci: fix bad print specifier
Date: Sat, 23 Feb 2013 09:00:12 -0800

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 685cbd2f63a48bd111bd2c3c4a2228029595ba12
      
https://github.com/qemu/qemu/commit/685cbd2f63a48bd111bd2c3c4a2228029595ba12
  Author: Hervé Poussineau <address@hidden>
  Date:   2013-02-23 (Sat, 23 Feb 2013)

  Changed paths:
    M hw/usb/hcd-xhci.c

  Log Message:
  -----------
  xhci: fix bad print specifier

This fixes the following compilation error:
hw/usb/hcd-xhci.c:1156:17: error: format ‘%llx’ expects argument of type
‘long long unsigned int’, but argument 4 has type ‘unsigned int’

Signed-off-by: Hervé Poussineau <address@hidden>
Reviewed-by: Stefan Weil <address@hidden>
Acked-by: Gerd Hoffmann <address@hidden>
Signed-off-by: Blue Swirl <address@hidden>


  Commit: 632314c49ce20ee9c974f07544d9125fbbbfbe1b
      
https://github.com/qemu/qemu/commit/632314c49ce20ee9c974f07544d9125fbbbfbe1b
  Author: Peter Maydell <address@hidden>
  Date:   2013-02-23 (Sat, 23 Feb 2013)

  Changed paths:
    M include/qemu/log.h
    M target-cris/translate.c
    M target-lm32/translate.c
    M target-microblaze/translate.c
    M target-openrisc/translate.c

  Log Message:
  -----------
  qemu-log: Remove qemu_log_try_set_file() and its users

Remove the function qemu_log_try_set_file() and its users (which
are all in TCG code generation functions for various targets).
This function was added to abstract out code which was originally
written as "if (!logfile) logfile = stderr;" in order that BUG:
case code which did an unguarded "fprintf(logfile, ...)" would
not crash if debug logging was not enabled. Since those direct
uses of logfile have also been abstracted away into qemu_log()
calls which check for a NULL logfile, there is no need for the
target-* files to mess with the user's chosen logging settings.

Signed-off-by: Peter Maydell <address@hidden>
Reviewed-by: Andreas Färber <address@hidden>
Acked-by: Michael Walle <address@hidden>
Signed-off-by: Blue Swirl <address@hidden>


  Commit: af18078d8057203b1ed26ac5534d233aabb36886
      
https://github.com/qemu/qemu/commit/af18078d8057203b1ed26ac5534d233aabb36886
  Author: Peter Maydell <address@hidden>
  Date:   2013-02-23 (Sat, 23 Feb 2013)

  Changed paths:
    M disas/i386.c

  Log Message:
  -----------
  disas/i386.c: Add explicit braces round empty for-loop body

Add explicit braces round an empty for-loop body; this fits
QEMU style and is easier to read than an inconspicuous semicolon
at the end of the line. It also silences a clang warning:

disas/i386.c:4723:49: warning: for loop has empty body [-Wempty-body]
    for (i = 0; tmp[i] == '0' && tmp[i + 1]; i++);
                                                 ^
disas/i386.c:4723:49: note: put the semicolon on a separate line to silence 
this warning [-Wempty-body]

Signed-off-by: Peter Maydell <address@hidden>
Signed-off-by: Blue Swirl <address@hidden>


  Commit: 8eda222831d31e6562bf1ce50d22fa29e1b6d958
      
https://github.com/qemu/qemu/commit/8eda222831d31e6562bf1ce50d22fa29e1b6d958
  Author: Fabien Chouteau <address@hidden>
  Date:   2013-02-23 (Sat, 23 Feb 2013)

  Changed paths:
    M hw/grlib_apbuart.c

  Log Message:
  -----------
  Typo: replace gptimer by apbuart

Signed-off-by: Fabien Chouteau <address@hidden>
Signed-off-by: Blue Swirl <address@hidden>


  Commit: 99e448006d9267d71c2e3a629b6e5d29ed67bb30
      
https://github.com/qemu/qemu/commit/99e448006d9267d71c2e3a629b6e5d29ed67bb30
  Author: Ronald Hecht <address@hidden>
  Date:   2013-02-23 (Sat, 23 Feb 2013)

  Changed paths:
    M hw/grlib_apbuart.c

  Log Message:
  -----------
  grlib-apbuart: Add support of various flags

 - enable/disable Rx and Tx
 - Rx and Tx interrupt
 - Tx FIFO empty and Tx SHIFT empty

Signed-off-by: Fabien Chouteau <address@hidden>
Signed-off-by: Blue Swirl <address@hidden>


  Commit: 7a0a9c2c64be242d5953d5ce6172976b05f6c14f
      
https://github.com/qemu/qemu/commit/7a0a9c2c64be242d5953d5ce6172976b05f6c14f
  Author: Ronald Hecht <address@hidden>
  Date:   2013-02-23 (Sat, 23 Feb 2013)

  Changed paths:
    M target-sparc/cpu.c
    M target-sparc/ldst_helper.c

  Log Message:
  -----------
  Added LEON MMU ASI mappings and corrected LEON3 MMU masks.

This patch adds SPARC ASI mappings that are used by the LEON processor.It also
corrects the MMU context register and context table pointer mask of the LEON3.

Signed-off-by: Ronald Hecht <address@hidden>
Signed-off-by: Fabien Chouteau <address@hidden>
Signed-off-by: Blue Swirl <address@hidden>


  Commit: d1c36ba707637173b818652e51181370d51b6c58
      
https://github.com/qemu/qemu/commit/d1c36ba707637173b818652e51181370d51b6c58
  Author: Ronald Hecht <address@hidden>
  Date:   2013-02-23 (Sat, 23 Feb 2013)

  Changed paths:
    M target-sparc/cpu.c
    M target-sparc/cpu.h
    M target-sparc/helper.c
    M target-sparc/helper.h
    M target-sparc/translate.c

  Log Message:
  -----------
  SPARC LEON power-down support added

Signed-off-by: Ronald Hecht <address@hidden>
Signed-off-by: Fabien Chouteau <address@hidden>
Signed-off-by: Blue Swirl <address@hidden>


  Commit: 6ab7e5465a4d6188e29398fb43a30dbab1015b75
      
https://github.com/qemu/qemu/commit/6ab7e5465a4d6188e29398fb43a30dbab1015b75
  Author: Peter Maydell <address@hidden>
  Date:   2013-02-23 (Sat, 23 Feb 2013)

  Changed paths:
    M coroutine-sigaltstack.c
    M coroutine-ucontext.c
    M cpu-exec.c
    M disas/i386.c
    M disas/m68k.c
    M include/exec/cpu-defs.h
    M include/sysemu/os-win32.h
    M monitor.c
    M user-exec.c

  Log Message:
  -----------
  Replace all setjmp()/longjmp() with sigsetjmp()/siglongjmp()

The setjmp() function doesn't specify whether signal masks are saved and
restored; on Linux they are not, but on BSD (including MacOSX) they are.
We want to have consistent behaviour across platforms, so we should
always use "don't save/restore signal mask" (this is also generally
going to be faster). This also works around a bug in MacOSX where the
signal-restoration on longjmp() affects the signal mask for a completely
different thread, not just the mask for the thread which did the longjmp.
The most visible effect of this was that ctrl-C was ignored on MacOSX
because the CPU thread did a longjmp which resulted in its signal mask
being applied to every thread, so that all threads had SIGINT and SIGTERM
blocked.

The POSIX-sanctioned portable way to do a jump without affecting signal
masks is to siglongjmp() to a sigjmp_buf which was created by calling
sigsetjmp() with a zero savemask parameter, so change all uses of
setjmp()/longjmp() accordingly. [Technically POSIX allows sigsetjmp(buf, 0)
to save the signal mask; however the following siglongjmp() must not
restore the signal mask, so the pair can be effectively considered as
"sigjmp/longjmp which don't touch the mask".]

For Windows we provide a trivial sigsetjmp/siglongjmp in terms of
setjmp/longjmp -- this is OK because no user will ever pass a non-zero
savemask.

The setjmp() uses in tests/tcg/test-i386.c and tests/tcg/linux-test.c
are left untouched because these are self-contained singlethreaded
test programs intended to be run under QEMU's Linux emulation, so they
have neither the portability nor the multithreading issues to deal with.

Signed-off-by: Peter Maydell <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Tested-by: Stefan Weil <address@hidden>
Reviewed-by: Laszlo Ersek <address@hidden>
Signed-off-by: Blue Swirl <address@hidden>


Compare: https://github.com/qemu/qemu/compare/30e8f22b7bc6...6ab7e5465a4d

reply via email to

[Prev in Thread] Current Thread [Next in Thread]