[Qemu-commits] [qemu/qemu] 4e298e: xilinx_axienet: Fix bit mask code

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 4e298e46ddcbb3a2a653a582b54557b75180c625
      
https://github.com/qemu/qemu/commit/4e298e46ddcbb3a2a653a582b54557b75180c625
  Author: Stefan Weil <address@hidden>
  Date:   2013-06-10 (Mon, 10 Jun 2013)

  Changed paths:
    M hw/net/xilinx_axienet.c

  Log Message:
  -----------
  xilinx_axienet: Fix bit mask code

Obviously the code wanted to mask the lower bits but failed to do so
because of a missing "<".

cppcheck detected a conditional expression which was always true (1 < 7).

Signed-off-by: Stefan Weil <address@hidden>
Signed-off-by: Edgar E. Iglesias <address@hidden>


  Commit: 4f293bd6e53739e089f33b458f70a9c4ac136b92
      
https://github.com/qemu/qemu/commit/4f293bd6e53739e089f33b458f70a9c4ac136b92
  Author: Wendy Liang <address@hidden>
  Date:   2013-06-10 (Mon, 10 Jun 2013)

  Changed paths:
    M hw/dma/xilinx_axidma.c

  Log Message:
  -----------
  xilinx_axidma: Do not set DMA .notify to NULL after notify

If a stream notify function is not ready, it may re-populate the notify call-
back to indicate it should be re-polled later. This break in this usage, as
immediately following the notify() call, .notify is set to NULL. reverse the
ordering of the notify call and NULL assignment accordingly.

[PC: Reworked commit message]

Signed-off-by: Wendy Liang <address@hidden>
Signed-off-by: Peter Crosthwaite <address@hidden>
Signed-off-by: Edgar E. Iglesias <address@hidden>


Compare: https://github.com/qemu/qemu/compare/7387de16d0e4...4f293bd6e537