[Qemu-commits] [qemu/qemu] 638129: s390x/kvm: Fix diagnose handling.

qemu-commits
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-commits] [qemu/qemu] 638129: s390x/kvm: Fix diagnose handling.

From:	GitHub
Subject:	[Qemu-commits] [qemu/qemu] 638129: s390x/kvm: Fix diagnose handling.
Date:	Sat, 21 Dec 2013 09:00:04 -0800
  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 638129ff475dd3b4c0e57e0be598efe41461e9b3
      
https://github.com/qemu/qemu/commit/638129ff475dd3b4c0e57e0be598efe41461e9b3
  Author: Cornelia Huck <address@hidden>
  Date:   2013-12-18 (Wed, 18 Dec 2013)

  Changed paths:
    M target-s390x/cpu.h
    M target-s390x/kvm.c

  Log Message:
  -----------
  s390x/kvm: Fix diagnose handling.

The instruction intercept handler for diagnose used only the displacement
when trying to calculate the function code. This is only correct for base
0, however; we need to perform a complete base/displacement address
calculation and use bits 48-63 as the function code.

Reviewed-by: Thomas Huth <address@hidden>
Signed-off-by: Cornelia Huck <address@hidden>
Signed-off-by: Jens Freimann <address@hidden>
Signed-off-by: Alexander Graf <address@hidden>


  Commit: 4f91e0b5d8b116c16964926a103e01623dbd81b6
      
https://github.com/qemu/qemu/commit/4f91e0b5d8b116c16964926a103e01623dbd81b6
  Author: Thomas Huth <address@hidden>
  Date:   2013-12-18 (Wed, 18 Dec 2013)

  Changed paths:
    M target-s390x/kvm.c

  Log Message:
  -----------
  s390x/kvm: Removed duplicated SIGP defines

The SIGP order defines are also available in cpu.h,
so there is no need to re-define them in kvm.c.

Signed-off-by: Thomas Huth <address@hidden>
Reviewed-by: Cornelia Huck <address@hidden>
Signed-off-by: Jens Freimann <address@hidden>
Signed-off-by: Alexander Graf <address@hidden>


  Commit: cd7a0f4cf905c421743357a55f107b86ee1ded9d
      
https://github.com/qemu/qemu/commit/cd7a0f4cf905c421743357a55f107b86ee1ded9d
  Author: Thomas Huth <address@hidden>
  Date:   2013-12-18 (Wed, 18 Dec 2013)

  Changed paths:
    M target-s390x/kvm.c

  Log Message:
  -----------
  s390x/kvm: Removed s390_store_status stub

The SIGP order STORE STATUS AT ADDRESS will be handled in
kernel space, so we do not need the stub in QEMU anymore.

Signed-off-by: Thomas Huth <address@hidden>
Reviewed-by: Cornelia Huck <address@hidden>
Signed-off-by: Jens Freimann <address@hidden>
Signed-off-by: Alexander Graf <address@hidden>


  Commit: 0b9972a2483b27824f3ec71b7b8b4a5961614216
      
https://github.com/qemu/qemu/commit/0b9972a2483b27824f3ec71b7b8b4a5961614216
  Author: Thomas Huth <address@hidden>
  Date:   2013-12-18 (Wed, 18 Dec 2013)

  Changed paths:
    M target-s390x/kvm.c

  Log Message:
  -----------
  s390x/kvm: Fix coding style in handle_sigp()

To make scripts/checkpatch.pl happy for the following patches,
the coding style in handle_sigp() has to be fixed first.

Signed-off-by: Thomas Huth <address@hidden>
Acked-by: Cornelia Huck <address@hidden>
Signed-off-by: Jens Freimann <address@hidden>
Signed-off-by: Alexander Graf <address@hidden>


  Commit: b20a461fcd55d2b05e729c587244eddc60b9527f
      
https://github.com/qemu/qemu/commit/b20a461fcd55d2b05e729c587244eddc60b9527f
  Author: Thomas Huth <address@hidden>
  Date:   2013-12-18 (Wed, 18 Dec 2013)

  Changed paths:
    M target-s390x/kvm.c

  Log Message:
  -----------
  s390x/kvm: Implemented SIGP START

This patch adds the missing START order to the SIGP instruction handler.

Signed-off-by: Thomas Huth <address@hidden>
Reviewed-by: Cornelia Huck <address@hidden>
Signed-off-by: Jens Freimann <address@hidden>
Signed-off-by: Alexander Graf <address@hidden>


  Commit: b8031adba791325907d8a9e19af8d483996974fd
      
https://github.com/qemu/qemu/commit/b8031adba791325907d8a9e19af8d483996974fd
  Author: Thomas Huth <address@hidden>
  Date:   2013-12-18 (Wed, 18 Dec 2013)

  Changed paths:
    M target-s390x/kvm.c

  Log Message:
  -----------
  s390x/kvm: Simplified the calculation of the SIGP order code

We've already got a helper function for calculating the
base/displacement of RS formatted instructions, so we can
get rid of the manual calculation of the SIGP order code.

Signed-off-by: Thomas Huth <address@hidden>
Reviewed-by: Cornelia Huck <address@hidden>
Signed-off-by: Jens Freimann <address@hidden>
Signed-off-by: Alexander Graf <address@hidden>


  Commit: 3796f0e1cda41eacf4fc915e7edaf54f2279466c
      
https://github.com/qemu/qemu/commit/3796f0e1cda41eacf4fc915e7edaf54f2279466c
  Author: Thomas Huth <address@hidden>
  Date:   2013-12-18 (Wed, 18 Dec 2013)

  Changed paths:
    M target-s390x/kvm.c

  Log Message:
  -----------
  s390x/kvm: Fixed condition code for unknown SIGP orders

If SIGP is called with an unknown order code, it has to return CC1
instead of CC3 and set the "invalid order" bit in the return status.

Signed-off-by: Thomas Huth <address@hidden>
Reviewed-by: Cornelia Huck <address@hidden>
Signed-off-by: Jens Freimann <address@hidden>
Signed-off-by: Alexander Graf <address@hidden>


  Commit: 10c8599a49f99180c2f79596325a5e856cdac59f
      
https://github.com/qemu/qemu/commit/10c8599a49f99180c2f79596325a5e856cdac59f
  Author: Thomas Huth <address@hidden>
  Date:   2013-12-18 (Wed, 18 Dec 2013)

  Changed paths:
    M target-s390x/ioinst.c

  Log Message:
  -----------
  s390x/ioinst: CHSC has to set a condition code

I missed to set the CC in the CHSC instruction when I refactored
the CC setting in the IO instructions with the following commit:
        5d9bf1c07c1369ab3506fc82cc65a10f4415d867
        s390/ioinst: Moved the CC setting to the IO instruction handlers
This patch now restores the correct behaviour of CHSC by setting the
condition code 0 at the end of the instruction.

Signed-off-by: Thomas Huth <address@hidden>
Reviewed-by: Cornelia Huck <address@hidden>
Signed-off-by: Jens Freimann <address@hidden>
Signed-off-by: Alexander Graf <address@hidden>


  Commit: 8589467f9419b86644a1a5ccab670c948e148efd
      
https://github.com/qemu/qemu/commit/8589467f9419b86644a1a5ccab670c948e148efd
  Author: Aurelien Jarno <address@hidden>
  Date:   2013-12-21 (Sat, 21 Dec 2013)

  Changed paths:
    M tcg/i386/tcg-target.c

  Log Message:
  -----------
  tcg/i386: fix a comment

The comments apply to 8-bit stores, not 8-byte stores.

Reviewed-by: Richard Henderson <address@hidden>
Signed-off-by: Aurelien Jarno <address@hidden>


  Commit: 5f68f5ae444725de4f35d99f1026155fadaf514b
      
https://github.com/qemu/qemu/commit/5f68f5ae444725de4f35d99f1026155fadaf514b
  Author: Aurelien Jarno <address@hidden>
  Date:   2013-12-21 (Sat, 21 Dec 2013)

  Changed paths:
    M target-mips/translate.c

  Log Message:
  -----------
  target-mips: Use new qemu_ld/st opcodes

Reviewed-by: Richard Henderson <address@hidden>
Signed-off-by: Aurelien Jarno <address@hidden>


  Commit: 3376f4151e4ce0534b35c49c56037cb347293c85
      
https://github.com/qemu/qemu/commit/3376f4151e4ce0534b35c49c56037cb347293c85
  Author: Aurelien Jarno <address@hidden>
  Date:   2013-12-21 (Sat, 21 Dec 2013)

  Changed paths:
    M target-sh4/translate.c

  Log Message:
  -----------
  target-sh4: Use new qemu_ld/st opcodes

Reviewed-by: Edgar E. Iglesias <address@hidden>
Signed-off-by: Aurelien Jarno <address@hidden>


  Commit: e8092f7ae1c71419829879e18ce2dd7249a4d00f
      
https://github.com/qemu/qemu/commit/e8092f7ae1c71419829879e18ce2dd7249a4d00f
  Author: Aurelien Jarno <address@hidden>
  Date:   2013-12-21 (Sat, 21 Dec 2013)

  Changed paths:
    M target-s390x/cpu.h
    M target-s390x/ioinst.c
    M target-s390x/kvm.c

  Log Message:
  -----------
  Merge tag 'signed-s390-for-upstream' of git://github.com/agraf/qemu

Patch queue for s390 - 2013-12-18

This covers mostly minor bug fixes and implements the SIGP START
hypercall which allows to start a remote CPU without changing its
state.

Cornelia Huck (1):
      s390x/kvm: Fix diagnose handling.

Thomas Huth (7):
      s390x/kvm: Removed duplicated SIGP defines
      s390x/kvm: Removed s390_store_status stub
      s390x/kvm: Fix coding style in handle_sigp()
      s390x/kvm: Implemented SIGP START
      s390x/kvm: Simplified the calculation of the SIGP order code
      s390x/kvm: Fixed condition code for unknown SIGP orders
      s390x/ioinst: CHSC has to set a condition code

* tag 'signed-s390-for-upstream' of git://github.com/agraf/qemu:
  s390x/ioinst: CHSC has to set a condition code
  s390x/kvm: Fixed condition code for unknown SIGP orders
  s390x/kvm: Simplified the calculation of the SIGP order code
  s390x/kvm: Implemented SIGP START
  s390x/kvm: Fix coding style in handle_sigp()
  s390x/kvm: Removed s390_store_status stub
  s390x/kvm: Removed duplicated SIGP defines
  s390x/kvm: Fix diagnose handling.


Compare: https://github.com/qemu/qemu/compare/f8251db121c3...e8092f7ae1c7
[Prev in Thread]
Current Thread
[Next in Thread]
[Qemu-commits] [qemu/qemu] 638129: s390x/kvm: Fix diagnose handling., GitHub <=
Prev by Date: [Qemu-commits] [qemu/qemu] c65f9a: target-ppc: add stubs for KVM breakpoints
Next by Date: [Qemu-commits] [qemu/qemu] f976b0: PPC: Fix compilation with TCG debug
Previous by thread: [Qemu-commits] [qemu/qemu] c65f9a: target-ppc: add stubs for KVM breakpoints
Next by thread: [Qemu-commits] [qemu/qemu] f976b0: PPC: Fix compilation with TCG debug
Index(es):
- Date
- Thread