[Qemu-commits] [qemu/qemu] cd159d: QMP: Allow dot separated dict path ar

qemu-commits
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-commits] [qemu/qemu] cd159d: QMP: Allow dot separated dict path ar

From:	GitHub
Subject:	[Qemu-commits] [qemu/qemu] cd159d: QMP: Allow dot separated dict path arguments in qm...
Date:	Tue, 04 Mar 2014 10:30:05 -0800
  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: cd159d0954f65df61864a85e355acdf7ae7fe0f9
      
https://github.com/qemu/qemu/commit/cd159d0954f65df61864a85e355acdf7ae7fe0f9
  Author: Fam Zheng <address@hidden>
  Date:   2014-02-28 (Fri, 28 Feb 2014)

  Changed paths:
    M scripts/qmp/qmp-shell

  Log Message:
  -----------
  QMP: Allow dot separated dict path arguments in qmp-shell

As another convenience to allow using commands that expect a dict as
argument, this patch adds support for foo.bar=value syntax, similar to
command line argument style:

  (QEMU) blockdev-add options.driver=file options.id=drive1 options.filename=...

Signed-off-by: Fam Zheng <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>
Signed-off-by: Luiz Capitulino <address@hidden>


  Commit: fbb0621a0f7aae2803d7460fc225402f9ea92000
      
https://github.com/qemu/qemu/commit/fbb0621a0f7aae2803d7460fc225402f9ea92000
  Author: Luiz Capitulino <address@hidden>
  Date:   2014-02-28 (Fri, 28 Feb 2014)

  Changed paths:
    M MAINTAINERS

  Log Message:
  -----------
  MAINTAINERS: update status for HMP, QAPI and QMP trees

This commit updates the status for the HMP, QAPI and QMP trees from
"Supported" to "Maintained".

In practice this means that patch review and pull requests may take
longer. Also, I'll rely more on reviewers such as Eric Blake so that
I'm able to send pull requests regularly.

Reviewed-by: Eric Blake <address@hidden>
Signed-off-by: Luiz Capitulino <address@hidden>


  Commit: b5ba1cc6260917926781fb79fbb05d53bf586d53
      
https://github.com/qemu/qemu/commit/b5ba1cc6260917926781fb79fbb05d53bf586d53
  Author: qiaonuohan <address@hidden>
  Date:   2014-02-28 (Fri, 28 Feb 2014)

  Changed paths:
    M dump.c
    M include/qom/cpu.h

  Log Message:
  -----------
  dump: const-qualify the buf of WriteCoreDumpFunction

WriteCoreDumpFunction is a function pointer that points to the function used to
write content in "buf" into core file, so "buf" should be const-qualify.

Signed-off-by: Qiao Nuohan <address@hidden>
Reviewed-by: Laszlo Ersek <address@hidden>
Signed-off-by: Luiz Capitulino <address@hidden>


  Commit: 6a519918b3f666759e20bcd0bb88378f3e4ffb57
      
https://github.com/qemu/qemu/commit/6a519918b3f666759e20bcd0bb88378f3e4ffb57
  Author: qiaonuohan <address@hidden>
  Date:   2014-02-28 (Fri, 28 Feb 2014)

  Changed paths:
    M dump.c

  Log Message:
  -----------
  dump: add argument to write_elfxx_notes

write_elf32_notes/wirte_elf64_notes use fd_write_vmcore to write elf notes to
vmcore. Adding parameter "WriteCoreDumpFunction f" makes it available to choose
the method of writing elf notes

Signed-off-by: Qiao Nuohan <address@hidden>
Reviewed-by: Laszlo Ersek <address@hidden>
Signed-off-by: Luiz Capitulino <address@hidden>


  Commit: fda053875e69120b2fde5fb34975ef5a49290f12
      
https://github.com/qemu/qemu/commit/fda053875e69120b2fde5fb34975ef5a49290f12
  Author: qiaonuohan <address@hidden>
  Date:   2014-02-28 (Fri, 28 Feb 2014)

  Changed paths:
    M dump.c
    M include/sysemu/dump.h

  Log Message:
  -----------
  dump: add API to write header of flatten format

flatten format will be used when writing kdump-compressed format. The format is
also used by makedumpfile, you can refer to the following URL to get more
detailed information about flatten format of kdump-compressed format:
http://sourceforge.net/projects/makedumpfile/

The two functions here are used to write start flat header and end flat header
to vmcore, and they will be called later when flatten format is used.

struct MakedumpfileHeader stored at the head of vmcore is used to indicate the
vmcore is in flatten format.

struct MakedumpfileHeader {
    char signature[16];     /* = "makedumpfile" */
    int64_t type;           /* = 1 */
    int64_t version;        /* = 1 */
};

And struct MakedumpfileDataHeader, with offset and buf_size set to -1, is used
to indicate the end of vmcore in flatten format.

struct MakedumpfileDataHeader {
    int64_t offset;         /* = -1 */
    int64_t buf_size;       /* = -1 */
};

Signed-off-by: Qiao Nuohan <address@hidden>
Reviewed-by: Laszlo Ersek <address@hidden>
Signed-off-by: Luiz Capitulino <address@hidden>


  Commit: 5d31babe5c7d854d6b8470bc9fa67a698926e65d
      
https://github.com/qemu/qemu/commit/5d31babe5c7d854d6b8470bc9fa67a698926e65d
  Author: qiaonuohan <address@hidden>
  Date:   2014-02-28 (Fri, 28 Feb 2014)

  Changed paths:
    M dump.c

  Log Message:
  -----------
  dump: add API to write vmcore

Function is used to write vmcore in flatten format. In flatten format, data is
written block by block, and in front of each block, a struct
MakedumpfileDataHeader is stored there to indicate the offset and size of the
data block.

struct MakedumpfileDataHeader {
    int64_t offset;
    int64_t buf_size;
};

Signed-off-by: Qiao Nuohan <address@hidden>
Reviewed-by: Laszlo Ersek <address@hidden>
Signed-off-by: Luiz Capitulino <address@hidden>


  Commit: 4835ef7784502c231f243c3133054850d23dd837
      
https://github.com/qemu/qemu/commit/4835ef7784502c231f243c3133054850d23dd837
  Author: qiaonuohan <address@hidden>
  Date:   2014-02-28 (Fri, 28 Feb 2014)

  Changed paths:
    M dump.c

  Log Message:
  -----------
  dump: add API to write elf notes to buffer

the function can be used by write_elf32_notes/write_elf64_notes to write notes
to a buffer. If fd_write_vmcore is used, write_elf32_notes/write_elf64_notes
will write elf notes to vmcore directly. Instead, if buf_write_note is used,
elf notes will be written to opaque->note_buf at first.

Signed-off-by: Qiao Nuohan <address@hidden>
Reviewed-by: Laszlo Ersek <address@hidden>
Signed-off-by: Luiz Capitulino <address@hidden>


  Commit: 607dacd0a082a4ea73a7a16a1c70406f37ebacdb
      
https://github.com/qemu/qemu/commit/607dacd0a082a4ea73a7a16a1c70406f37ebacdb
  Author: qiaonuohan <address@hidden>
  Date:   2014-02-28 (Fri, 28 Feb 2014)

  Changed paths:
    M configure

  Log Message:
  -----------
  dump: add support for lzo/snappy

kdump-compressed format supports three compression format, zlib/lzo/snappy.
Currently, only zlib is available. This patch is used to support lzo/snappy.
'--enable-lzo/--enable-snappy' is needed to be specified with configure to make
lzo/snappy available for qemu

Signed-off-by: Qiao Nuohan <address@hidden>
Reviewed-by: Laszlo Ersek <address@hidden>
Signed-off-by: Luiz Capitulino <address@hidden>


  Commit: 7aad248d3596a1fb94778f2cd215f86a802b3abb
      
https://github.com/qemu/qemu/commit/7aad248d3596a1fb94778f2cd215f86a802b3abb
  Author: qiaonuohan <address@hidden>
  Date:   2014-02-28 (Fri, 28 Feb 2014)

  Changed paths:
    M dump.c
    M include/sysemu/dump.h

  Log Message:
  -----------
  dump: add members to DumpState and init some of them

add some members to DumpState that will be used in writing vmcore in
kdump-compressed format. some of them, like page_size, will be initialized
in the patch.

Signed-off-by: Qiao Nuohan <address@hidden>
Reviewed-by: Laszlo Ersek <address@hidden>
Signed-off-by: Luiz Capitulino <address@hidden>


  Commit: 298f116827405f37dde10a2a6cbc75d20f9ba99c
      
https://github.com/qemu/qemu/commit/298f116827405f37dde10a2a6cbc75d20f9ba99c
  Author: qiaonuohan <address@hidden>
  Date:   2014-02-28 (Fri, 28 Feb 2014)

  Changed paths:
    M dump.c
    M include/sysemu/dump.h

  Log Message:
  -----------
  dump: add API to write dump header

the functions are used to write header of kdump-compressed format to vmcore.
Header of kdump-compressed format includes:
1. common header: DiskDumpHeader32 / DiskDumpHeader64
2. sub header: KdumpSubHeader32 / KdumpSubHeader64
3. extra information: only elf notes here

Signed-off-by: Qiao Nuohan <address@hidden>
Reviewed-by: Laszlo Ersek <address@hidden>
Signed-off-by: Luiz Capitulino <address@hidden>


  Commit: d0686c7291fe8f0210e7a666f80892fa71395510
      
https://github.com/qemu/qemu/commit/d0686c7291fe8f0210e7a666f80892fa71395510
  Author: qiaonuohan <address@hidden>
  Date:   2014-02-28 (Fri, 28 Feb 2014)

  Changed paths:
    M dump.c
    M include/sysemu/dump.h

  Log Message:
  -----------
  dump: add API to write dump_bitmap

functions are used to write 1st and 2nd dump_bitmap of kdump-compressed format,
which is used to indicate whether the corresponded page is existed in vmcore.
1st and 2nd dump_bitmap are same, because dump level is specified to 1 here.

Signed-off-by: Qiao Nuohan <address@hidden>
Reviewed-by: Laszlo Ersek <address@hidden>
Signed-off-by: Luiz Capitulino <address@hidden>


  Commit: 64cfba6a47411092c941c8d17256fb5673cc8cbf
      
https://github.com/qemu/qemu/commit/64cfba6a47411092c941c8d17256fb5673cc8cbf
  Author: qiaonuohan <address@hidden>
  Date:   2014-02-28 (Fri, 28 Feb 2014)

  Changed paths:
    M dump.c
    M include/sysemu/dump.h

  Log Message:
  -----------
  dump: add APIs to operate DataCache

DataCache is used to store data temporarily, then the data will be written to
vmcore. These functions will be called later when writing data of page to
vmcore.

Signed-off-by: Qiao Nuohan <address@hidden>
Reviewed-by: Laszlo Ersek <address@hidden>
Signed-off-by: Luiz Capitulino <address@hidden>


  Commit: d12f57ec6640d36e380367a0ab6ab9f3f29b6d51
      
https://github.com/qemu/qemu/commit/d12f57ec6640d36e380367a0ab6ab9f3f29b6d51
  Author: qiaonuohan <address@hidden>
  Date:   2014-02-28 (Fri, 28 Feb 2014)

  Changed paths:
    M dump.c
    M include/sysemu/dump.h

  Log Message:
  -----------
  dump: add API to write dump pages

functions are used to write page to vmcore. vmcore is written page by page.
page desc is used to store the information of a page, including a page's size,
offset, compression format, etc.

Signed-off-by: Qiao Nuohan <address@hidden>
Reviewed-by: Laszlo Ersek <address@hidden>
Signed-off-by: Luiz Capitulino <address@hidden>


  Commit: b53ccc30c40df52d192e469a86c188a8649c6df3
      
https://github.com/qemu/qemu/commit/b53ccc30c40df52d192e469a86c188a8649c6df3
  Author: qiaonuohan <address@hidden>
  Date:   2014-02-28 (Fri, 28 Feb 2014)

  Changed paths:
    M dump.c
    M hmp.c
    M qapi-schema.json
    M qmp-commands.hx

  Log Message:
  -----------
  dump: make kdump-compressed format available for 'dump-guest-memory'

Make monitor command 'dump-guest-memory' be able to dump in kdump-compressed
format. The command's usage:

  dump [-p] protocol [begin] [length] [format]

'format' is used to specified the format of vmcore and can be:
1. 'elf': ELF format, without compression
2. 'kdump-zlib': kdump-compressed format, with zlib-compressed
3. 'kdump-lzo': kdump-compressed format, with lzo-compressed
4. 'kdump-snappy': kdump-compressed format, with snappy-compressed
Without 'format' being set, it is same as 'elf'. And if non-elf format is
specified, paging and filter is not allowed.

Note:
  1. The kdump-compressed format is readable only with the crash utility and
     makedumpfile, and it can be smaller than the ELF format because of the
     compression support.
  2. The kdump-compressed format is the 6th edition.

Signed-off-by: Qiao Nuohan <address@hidden>
Reviewed-by: Laszlo Ersek <address@hidden>
Signed-off-by: Luiz Capitulino <address@hidden>


  Commit: 4ab23a918249772458fd330758dc0fad96edce50
      
https://github.com/qemu/qemu/commit/4ab23a918249772458fd330758dc0fad96edce50
  Author: qiaonuohan <address@hidden>
  Date:   2014-02-28 (Fri, 28 Feb 2014)

  Changed paths:
    M dump.c
    M target-i386/cpu.h
    M target-s390x/cpu.h

  Log Message:
  -----------
  Define the architecture for compressed dump format

Signed-off-by: Ekaterina Tumanova <address@hidden>
Reviewed-by: Laszlo Ersek <address@hidden>
Reviewed-by: Qiao Nuohan <address@hidden>
Signed-off-by: Luiz Capitulino <address@hidden>


  Commit: 7d6dc7f30c4781857ce230333da6ddd21fe0dcde
      
https://github.com/qemu/qemu/commit/7d6dc7f30c4781857ce230333da6ddd21fe0dcde
  Author: qiaonuohan <address@hidden>
  Date:   2014-02-28 (Fri, 28 Feb 2014)

  Changed paths:
    M dump.c
    M qapi-schema.json
    M qmp-commands.hx

  Log Message:
  -----------
  dump: add 'query-dump-guest-memory-capability' command

'query-dump-guest-memory-capability' is used to query the available formats for
'dump-guest-memory'. The output of the command will be like:

-> { "execute": "query-dump-guest-memory-capability" }
<- { "return": { "formats":
              ["elf", "kdump-zlib", "kdump-lzo", "kdump-snappy"] }

Signed-off-by: Qiao Nuohan <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Signed-off-by: Luiz Capitulino <address@hidden>


  Commit: 4864512389b06389501e60d965edb8defb66a0fc
      
https://github.com/qemu/qemu/commit/4864512389b06389501e60d965edb8defb66a0fc
  Author: Fam Zheng <address@hidden>
  Date:   2014-02-28 (Fri, 28 Feb 2014)

  Changed paths:
    M scripts/qmp/qmp.py

  Log Message:
  -----------
  qmp: Check for returned data from __json_read in get_events

When QEMU process aborts and socket is closed, qmp client will not
detect it. When this happens, some qemu-iotests scripts will enter an
endless loop waiting for qmp events.

It's better we raise an exception in qmp.py to catch this and make the
test script stop.

Signed-off-by: Fam Zheng <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>
Signed-off-by: Luiz Capitulino <address@hidden>


  Commit: ffe9fe3a25b93c045acc4d929056f8ea776a160a
      
https://github.com/qemu/qemu/commit/ffe9fe3a25b93c045acc4d929056f8ea776a160a
  Author: Hani Benhabiles <address@hidden>
  Date:   2014-02-28 (Fri, 28 Feb 2014)

  Changed paths:
    M include/qapi/qmp/qerror.h

  Log Message:
  -----------
  qerror: Improve QERR_DEVICE_NOT_ACTIVE message

The error message as currently used is confusing as there are no "balloon" or
"spice" devices.

(qemu) balloon 1024
balloon: Device 'balloon' has not been activated

With this patch:

(qemu) balloon 1024
balloon: No balloon device has been activated

Signed-off-by: Hani Benhabiles <address@hidden>
Suggested-by: Markus Armbruster <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
Signed-off-by: Luiz Capitulino <address@hidden>


  Commit: de92f3f86adc73db1ee8d1eebdfcf3b59476495b
      
https://github.com/qemu/qemu/commit/de92f3f86adc73db1ee8d1eebdfcf3b59476495b
  Author: Hani Benhabiles <address@hidden>
  Date:   2014-02-28 (Fri, 28 Feb 2014)

  Changed paths:
    M monitor.c

  Log Message:
  -----------
  monitor: Remove left-over code in do_info_profile.

This is a left-over from 4a1418e.

Signed-off-by: Hani Benhabiles <address@hidden>
Signed-off-by: Luiz Capitulino <address@hidden>


  Commit: 357765fed57de3204cb259db3ffa3737e33ca5c0
      
https://github.com/qemu/qemu/commit/357765fed57de3204cb259db3ffa3737e33ca5c0
  Author: Markus Armbruster <address@hidden>
  Date:   2014-03-03 (Mon, 03 Mar 2014)

  Changed paths:
    M tests/test-qmp-commands.c

  Log Message:
  -----------
  tests/qapi-schema: Actually check successful QMP command response

Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Signed-off-by: Luiz Capitulino <address@hidden>


  Commit: ab22ad96cea4300a92b400b0c46af2f50a037362
      
https://github.com/qemu/qemu/commit/ab22ad96cea4300a92b400b0c46af2f50a037362
  Author: Markus Armbruster <address@hidden>
  Date:   2014-03-03 (Mon, 03 Mar 2014)

  Changed paths:
    M tests/qapi-schema/qapi-schema-test.json
    M tests/qapi-schema/qapi-schema-test.out
    M tests/test-qmp-commands.c

  Log Message:
  -----------
  tests/qapi-schema: Cover optional command arguments

Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Signed-off-by: Luiz Capitulino <address@hidden>


  Commit: c2216a8a7a587e594f50bebbdf81fcf168444b68
      
https://github.com/qemu/qemu/commit/c2216a8a7a587e594f50bebbdf81fcf168444b68
  Author: Markus Armbruster <address@hidden>
  Date:   2014-03-03 (Mon, 03 Mar 2014)

  Changed paths:
    M tests/qapi-schema/qapi-schema-test.json
    M tests/qapi-schema/qapi-schema-test.out
    M tests/test-qmp-commands.c

  Log Message:
  -----------
  tests/qapi-schema: Cover simple argument types

Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Signed-off-by: Luiz Capitulino <address@hidden>


  Commit: 2c38b600109edcad399ca687024b7a7febd80076
      
https://github.com/qemu/qemu/commit/2c38b600109edcad399ca687024b7a7febd80076
  Author: Markus Armbruster <address@hidden>
  Date:   2014-03-03 (Mon, 03 Mar 2014)

  Changed paths:
    M tests/qapi-schema/qapi-schema-test.json
    M tests/qapi-schema/qapi-schema-test.out
    M tests/test-qmp-input-strict.c
    M tests/test-qmp-input-visitor.c
    M tests/test-qmp-output-visitor.c

  Log Message:
  -----------
  tests/qapi-schema: Cover anonymous union types

Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Signed-off-by: Luiz Capitulino <address@hidden>


  Commit: aabbd472a08249335d6a004173b30d552cb70d1d
      
https://github.com/qemu/qemu/commit/aabbd472a08249335d6a004173b30d552cb70d1d
  Author: Markus Armbruster <address@hidden>
  Date:   2014-03-03 (Mon, 03 Mar 2014)

  Changed paths:
    M tests/qapi-schema/qapi-schema-test.json
    M tests/qapi-schema/qapi-schema-test.out
    M tests/test-qmp-commands.c
    M tests/test-qmp-input-visitor.c
    M tests/test-qmp-output-visitor.c
    M tests/test-visitor-serialization.c

  Log Message:
  -----------
  tests/qapi-schema: Cover complex types with base

Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Signed-off-by: Luiz Capitulino <address@hidden>


  Commit: 7ad993b480d3f4f1261d3374516effd9bff20bc6
      
https://github.com/qemu/qemu/commit/7ad993b480d3f4f1261d3374516effd9bff20bc6
  Author: Markus Armbruster <address@hidden>
  Date:   2014-03-03 (Mon, 03 Mar 2014)

  Changed paths:
    M tests/qapi-schema/qapi-schema-test.json
    M tests/qapi-schema/qapi-schema-test.out
    M tests/test-qmp-input-strict.c
    M tests/test-qmp-input-visitor.c
    M tests/test-qmp-output-visitor.c

  Log Message:
  -----------
  tests/qapi-schema: Cover union types with base

Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Signed-off-by: Luiz Capitulino <address@hidden>


  Commit: 2fc00432830e42e3c24850a379194a61f09e3663
      
https://github.com/qemu/qemu/commit/2fc00432830e42e3c24850a379194a61f09e3663
  Author: Markus Armbruster <address@hidden>
  Date:   2014-03-03 (Mon, 03 Mar 2014)

  Changed paths:
    M tests/qapi-schema/qapi-schema-test.json
    M tests/qapi-schema/qapi-schema-test.out
    M tests/test-qmp-input-strict.c
    M tests/test-qmp-input-visitor.c
    M tests/test-qmp-output-visitor.c

  Log Message:
  -----------
  tests/qapi-schema: Cover flat union types

The test demonstrates a generator bug: the generated struct
UserDefFlatUnion doesn't include members for the indirect base
UserDefZero.

Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Signed-off-by: Luiz Capitulino <address@hidden>


  Commit: 678e48a2e43d1cafbb510c60d7597897b0d90256
      
https://github.com/qemu/qemu/commit/678e48a2e43d1cafbb510c60d7597897b0d90256
  Author: Markus Armbruster <address@hidden>
  Date:   2014-03-03 (Mon, 03 Mar 2014)

  Changed paths:
    M scripts/qapi-commands.py
    M scripts/qapi-types.py
    M scripts/qapi-visit.py
    M scripts/qapi.py

  Log Message:
  -----------
  qapi: Fix licensing of scripts

The scripts carry this copyright notice:

    # This work is licensed under the terms of the GNU GPLv2.
    # See the COPYING.LIB file in the top-level directory.

The sentences contradict each other, as COPYING.LIB contains the LGPL
2.1.  Michael Roth says this was a simple pasto, and he meant to refer
COPYING.  Let's fix that.

Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Signed-off-by: Luiz Capitulino <address@hidden>


  Commit: a105acbce3954cb31ab30cae04f489dfe07cfd02
      
https://github.com/qemu/qemu/commit/a105acbce3954cb31ab30cae04f489dfe07cfd02
  Author: Markus Armbruster <address@hidden>
  Date:   2014-03-03 (Mon, 03 Mar 2014)

  Changed paths:
    M scripts/qapi-visit.py

  Log Message:
  -----------
  qapi: Drop nonsensical header guard in generated qapi-visit.c

Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Signed-off-by: Luiz Capitulino <address@hidden>


  Commit: 56bed4135f139721d42992da3924786282bb0286
      
https://github.com/qemu/qemu/commit/56bed4135f139721d42992da3924786282bb0286
  Author: Markus Armbruster <address@hidden>
  Date:   2014-03-03 (Mon, 03 Mar 2014)

  Changed paths:
    M scripts/qapi-commands.py

  Log Message:
  -----------
  qapi: Drop unused code in qapi-commands.py

Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Signed-off-by: Luiz Capitulino <address@hidden>


  Commit: 949ceeb31b84dce43e4619b6d7f02cac0e62e1e1
      
https://github.com/qemu/qemu/commit/949ceeb31b84dce43e4619b6d7f02cac0e62e1e1
  Author: Markus Armbruster <address@hidden>
  Date:   2014-03-03 (Mon, 03 Mar 2014)

  Changed paths:
    M scripts/qapi-visit.py

  Log Message:
  -----------
  qapi: Clean up null checking in generated visitors

Visitors get passed a pointer to the visited object.  The generated
visitors try to cope with this pointer being null in some places, for
instance like this:

    visit_start_optional(m, obj ? &(*obj)->has_name : NULL, "name", &err);

visit_start_optional() passes its second argument to Visitor method
start_optional.  Three out of three methods dereference it
unconditionally.

I fail to see how this pointer could legitimately be null.

All this useless null checking is highly redundant, which Coverity
duly reports.  About 200 times.

Remove the useless null checks.

Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Signed-off-by: Luiz Capitulino <address@hidden>


  Commit: 25a7017555f1b4aeb543b5d323ff4afb8f9c5437
      
https://github.com/qemu/qemu/commit/25a7017555f1b4aeb543b5d323ff4afb8f9c5437
  Author: Markus Armbruster <address@hidden>
  Date:   2014-03-03 (Mon, 03 Mar 2014)

  Changed paths:
    M qapi/qapi-dealloc-visitor.c

  Log Message:
  -----------
  qapi: Clean up superfluous null check in qapi_dealloc_type_str()

Argument can't be null.  No other Visitor method type_str() checks for
null.

Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Signed-off-by: Luiz Capitulino <address@hidden>


  Commit: b774539743c52ef605c6e2cbac19376c2757cb86
      
https://github.com/qemu/qemu/commit/b774539743c52ef605c6e2cbac19376c2757cb86
  Author: Markus Armbruster <address@hidden>
  Date:   2014-03-03 (Mon, 03 Mar 2014)

  Changed paths:
    M qapi/opts-visitor.c

  Log Message:
  -----------
  qapi: Add missing null check to opts_start_struct()

Argument is null when visiting an unboxed struct.  I can't see such a
visit in the current code.  Fix it anyway.

Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Signed-off-by: Luiz Capitulino <address@hidden>


  Commit: e00ef747f08db1c7dd58a5366db4dc3038a7307f
      
https://github.com/qemu/qemu/commit/e00ef747f08db1c7dd58a5366db4dc3038a7307f
  Author: Peter Maydell <address@hidden>
  Date:   2014-03-04 (Tue, 04 Mar 2014)

  Changed paths:
    M MAINTAINERS
    M configure
    M dump.c
    M hmp.c
    M include/qapi/qmp/qerror.h
    M include/qom/cpu.h
    M include/sysemu/dump.h
    M monitor.c
    M qapi-schema.json
    M qapi/opts-visitor.c
    M qapi/qapi-dealloc-visitor.c
    M qmp-commands.hx
    M scripts/qapi-commands.py
    M scripts/qapi-types.py
    M scripts/qapi-visit.py
    M scripts/qapi.py
    M scripts/qmp/qmp-shell
    M scripts/qmp/qmp.py
    M target-i386/cpu.h
    M target-s390x/cpu.h
    M tests/qapi-schema/qapi-schema-test.json
    M tests/qapi-schema/qapi-schema-test.out
    M tests/test-qmp-commands.c
    M tests/test-qmp-input-strict.c
    M tests/test-qmp-input-visitor.c
    M tests/test-qmp-output-visitor.c
    M tests/test-visitor-serialization.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/qmp-unstable/queue/qmp' into staging

* remotes/qmp-unstable/queue/qmp: (32 commits)
  qapi: Add missing null check to opts_start_struct()
  qapi: Clean up superfluous null check in qapi_dealloc_type_str()
  qapi: Clean up null checking in generated visitors
  qapi: Drop unused code in qapi-commands.py
  qapi: Drop nonsensical header guard in generated qapi-visit.c
  qapi: Fix licensing of scripts
  tests/qapi-schema: Cover flat union types
  tests/qapi-schema: Cover union types with base
  tests/qapi-schema: Cover complex types with base
  tests/qapi-schema: Cover anonymous union types
  tests/qapi-schema: Cover simple argument types
  tests/qapi-schema: Cover optional command arguments
  tests/qapi-schema: Actually check successful QMP command response
  monitor: Remove left-over code in do_info_profile.
  qerror: Improve QERR_DEVICE_NOT_ACTIVE message
  qmp: Check for returned data from __json_read in get_events
  dump: add 'query-dump-guest-memory-capability' command
  Define the architecture for compressed dump format
  dump: make kdump-compressed format available for 'dump-guest-memory'
  dump: add API to write dump pages
  ...

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/4a29420ea1c5...e00ef747f08d
[Prev in Thread]
Current Thread
[Next in Thread]
[Qemu-commits] [qemu/qemu] cd159d: QMP: Allow dot separated dict path arguments in qm..., GitHub <=
Prev by Date: [Qemu-commits] [qemu/qemu] 9a05fe: qemu-iotests: add more tests to the "quick" group
Next by Date: [Qemu-commits] [qemu/qemu] 1c884a: include/qemu/host-utils.h: Trivial typo: ctz->cto
Previous by thread: [Qemu-commits] [qemu/qemu] 9a05fe: qemu-iotests: add more tests to the "quick" group
Next by thread: [Qemu-commits] [qemu/qemu] 1c884a: include/qemu/host-utils.h: Trivial typo: ctz->cto
Index(es):
- Date
- Thread