[Qemu-commits] [qemu/qemu] cf8645: vnc: refuse to set a password with VNC_AUTH_NONE

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: cf864569cd9134ee503ad9eb6be2881001c0ed80
      
https://github.com/qemu/qemu/commit/cf864569cd9134ee503ad9eb6be2881001c0ed80
  Author: Gerd Hoffmann <address@hidden>
  Date:   2014-06-02 (Mon, 02 Jun 2014)

  Changed paths:
    M ui/vnc.c

  Log Message:
  -----------
  vnc: refuse to set a password with VNC_AUTH_NONE

Current code silently changes the authentication settings
in case you try to set a password without password authentication
turned on.  This is bad.  Return an error instead.

If we want allow changing auth settings at runtime this should
be done explicitly using a separate monitor command, not as
side effect of set_passwd.

Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: 4006617552892a1fe3a5a1f4d103613404abc409
      
https://github.com/qemu/qemu/commit/4006617552892a1fe3a5a1f4d103613404abc409
  Author: Gerd Hoffmann <address@hidden>
  Date:   2014-06-02 (Mon, 02 Jun 2014)

  Changed paths:
    M trace-events
    M ui/vnc.c

  Log Message:
  -----------
  vnc: add trace events for key events

Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: b52991537c0efe27ee0c1955eb28a4584226d8b5
      
https://github.com/qemu/qemu/commit/b52991537c0efe27ee0c1955eb28a4584226d8b5
  Author: Gonglei <address@hidden>
  Date:   2014-06-02 (Mon, 02 Jun 2014)

  Changed paths:
    M ui/vnc-enc-tight.c

  Log Message:
  -----------
  vnc-enc-tight: Fix divide-by-zero in tight_detect_smooth_image{16,24,32}

Spotted by Coverity:

(1) Event assignment:  Assigning: "pixels" = "0".
(2) Event cond_true:  Condition "y < h", taking true branch
(3) Event cond_false:  Condition "x < w", taking false branch
(4) Event loop_end:  Reached end of loop
(5) Event divide_by_zero:  In expression "(stats[0] + stats[1]) * 100U / 
pixels",
division by expression "pixels" which may be zero has undefined behavior.

290     DEFINE_DETECT_FUNCTION(16)
291     DEFINE_DETECT_FUNCTION(32)

Signed-off-by: Gonglei <address@hidden>
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: 36f5db59cff03fd289541da104249f00356a19a7
      
https://github.com/qemu/qemu/commit/36f5db59cff03fd289541da104249f00356a19a7
  Author: Peter Maydell <address@hidden>
  Date:   2014-06-02 (Mon, 02 Jun 2014)

  Changed paths:
    M trace-events
    M ui/vnc-enc-tight.c
    M ui/vnc.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/kraxel/tags/pull-vnc-3' into staging

misc minor vnc patches

# gpg: Signature made Mon 02 Jun 2014 15:31:53 BST using RSA key ID D3E87138
# gpg: Good signature from "Gerd Hoffmann (work) <address@hidden>"
# gpg:                 aka "Gerd Hoffmann <address@hidden>"
# gpg:                 aka "Gerd Hoffmann (private) <address@hidden>"

* remotes/kraxel/tags/pull-vnc-3:
  vnc-enc-tight: Fix divide-by-zero in tight_detect_smooth_image{16,24,32}
  vnc: add trace events for key events
  vnc: refuse to set a password with VNC_AUTH_NONE

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/f72b49398ffa...36f5db59cff0