[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] bc78cf: trace: add qemu_system_powerdown_requ

From: GitHub
Subject: [Qemu-commits] [qemu/qemu] bc78cf: trace: add qemu_system_powerdown_request and qemu_...
Date: Tue, 01 Jul 2014 07:30:06 -0700

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: bc78cff9757782501db15d39828e6af4186fe331
  Author: Yang Zhiyong <address@hidden>
  Date:   2014-07-01 (Tue, 01 Jul 2014)

  Changed paths:
    M trace-events
    M vl.c

  Log Message:
  trace: add qemu_system_powerdown_request and qemu_system_shutdown_request 
trace events

We have the experience that the guest doesn't stop successfully
though it was instructed to shut down.

The root cause may be not in QEMU mostly.  However, QEMU is often
suspected at the beginning just because the issue occurred in
virtualization environment.

Therefore, we need to affirm that QEMU received the shutdown
request and raised ACPI irq from "virsh shutdown" command,
virt-manger or stopping QEMU process to the VM .
So that we can affirm the problems was belonged to the Guset OS
rather than the QEMU itself.

When we stop guests by "virsh shutdown" command or virt-manger,
or stopping QEMU process, qemu_system_powerdown_request() or
qemu_system_shutdown_request() is called. Then the below functions
in main_loop_should_exit() of Vl.c are called roughly in the
following order.

        if (qemu_powerdown_requested())
                        monitor_protocol_event(QEVENT_POWERDOWN, NULL)


                monitor_protocol_event(QEVENT_SHUTDOWN, NULL);

The tracepoint of monitor_protocol_event() already exists, but no
tracepoints are defined for qemu_system_powerdown_request() and
qemu_system_shutdown_request(). So this patch adds two tracepoints for
the two functions. We believe that it will become much easier to
isolate the problem mentioned above by these tracepoints.

Signed-off-by: Yang Zhiyong <address@hidden>
Signed-off-by: Stefan Hajnoczi <address@hidden>

  Commit: 1aa85f46b336b6b07d3a03e9807578b0bc081b7b
  Author: Peter Maydell <address@hidden>
  Date:   2014-07-01 (Tue, 01 Jul 2014)

  Changed paths:
    M trace-events
    M vl.c

  Log Message:
  Merge remote-tracking branch 'remotes/stefanha/tags/tracing-pull-request' 
into staging

Tracing pull request

# gpg: Signature made Tue 01 Jul 2014 09:56:27 BST using RSA key ID 81AB73C8
# gpg: Good signature from "Stefan Hajnoczi <address@hidden>"
# gpg:                 aka "Stefan Hajnoczi <address@hidden>"

* remotes/stefanha/tags/tracing-pull-request:
  trace: add qemu_system_powerdown_request and qemu_system_shutdown_request 
trace events

Signed-off-by: Peter Maydell <address@hidden>

Compare: https://github.com/qemu/qemu/compare/8593efa4fb33...1aa85f46b336

reply via email to

[Prev in Thread] Current Thread [Next in Thread]