[Qemu-commits] [qemu/qemu] 1b6f85: 9pfs-local: simplify/optimize local_mapped_attr_pa...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 1b6f85e2cb9302a8587772d04983a3ecc0ecfe68
      
https://github.com/qemu/qemu/commit/1b6f85e2cb9302a8587772d04983a3ecc0ecfe68
  Author: Michael Tokarev <address@hidden>
  Date:   2015-03-12 (Thu, 12 Mar 2015)

  Changed paths:
    M hw/9pfs/virtio-9p-local.c

  Log Message:
  -----------
  9pfs-local: simplify/optimize local_mapped_attr_path()

Omit one unnecessary memory allocation for components
of the path and create the resulting path directly given
lengths of the components.

Do not use basename(3) because there are 2 versions of
this function which differs when argument ends with
slash character, use strrchr() instead so we have
consistent result.  This also makes sure the function
will do the right thing in corner cases (eg, empty
pathname is given), when basename(3) return entirely
another string.

Signed-off-by: Michael Tokarev <address@hidden>
Signed-off-by: Aneesh Kumar K.V <address@hidden>


  Commit: 7752efcacf41daf34f9fefc5e78131f2afa3d4d7
      
https://github.com/qemu/qemu/commit/7752efcacf41daf34f9fefc5e78131f2afa3d4d7
  Author: Michael Tokarev <address@hidden>
  Date:   2015-03-12 (Thu, 12 Mar 2015)

  Changed paths:
    M hw/9pfs/virtio-9p-proxy.c

  Log Message:
  -----------
  9pfs-proxy: tiny cleanups in proxy_pwritev and proxy_preadv

Don't compare syscall return with -1, use "<0" condition.
Don't introduce useless local variables when we already
have similar variable
Rename local variable to be consistent with other usages
Finally make the two methods, read and write, to be similar to each other

Signed-off-by: Michael Tokarev <address@hidden>
Signed-off-by: Aneesh Kumar K.V <address@hidden>


  Commit: 9005c3b3efb7eb1b140d2ad0385efff6a3af59c4
      
https://github.com/qemu/qemu/commit/9005c3b3efb7eb1b140d2ad0385efff6a3af59c4
  Author: Shannon Zhao <address@hidden>
  Date:   2015-03-13 (Fri, 13 Mar 2015)

  Changed paths:
    M hw/9pfs/virtio-9p-posix-acl.c

  Log Message:
  -----------
  hw/9pfs/virtio-9p-posix-acl: Fix out-of-bounds access

It's detected by coverity. Fix out-of-bounds access of the function 
mp_dacl_listxattr.

Signed-off-by: Shannon Zhao <address@hidden>
Signed-off-by: Shannon Zhao <address@hidden>
Signed-off-by: Aneesh Kumar K.V <address@hidden>


  Commit: 821c447675728ca06c8d2e4ac8a0e7a1adf775b8
      
https://github.com/qemu/qemu/commit/821c447675728ca06c8d2e4ac8a0e7a1adf775b8
  Author: Shannon Zhao <address@hidden>
  Date:   2015-03-16 (Mon, 16 Mar 2015)

  Changed paths:
    M fsdev/virtfs-proxy-helper.c

  Log Message:
  -----------
  fsdev/virtfs-proxy-helper: Fix improper use of negative value

It's detected by coverity. Check the return value of proxy_marshal.

Signed-off-by: Shannon Zhao <address@hidden>
Signed-off-by: Shannon Zhao <address@hidden>
Signed-off-by: Aneesh Kumar K.V <address@hidden>


  Commit: 25ee9a7fa3f4e09fde48bb184447ff5651ed5fd8
      
https://github.com/qemu/qemu/commit/25ee9a7fa3f4e09fde48bb184447ff5651ed5fd8
  Author: Shannon Zhao <address@hidden>
  Date:   2015-03-16 (Mon, 16 Mar 2015)

  Changed paths:
    M fsdev/virtfs-proxy-helper.c
    M hw/9pfs/virtio-9p-proxy.c

  Log Message:
  -----------
  virtfs-proxy: Fix possible overflow

It's detected by coverity. The socket name specified
should fit in the sockadd_un.sun_path. If not abort.

Signed-off-by: Shannon Zhao <address@hidden>
Signed-off-by: Shannon Zhao <address@hidden>
Signed-off-by: Aneesh Kumar K.V <address@hidden>


  Commit: 4ed7b2c3a78f785a1bcbe575e08c379b166723e3
      
https://github.com/qemu/qemu/commit/4ed7b2c3a78f785a1bcbe575e08c379b166723e3
  Author: Stefan Weil <address@hidden>
  Date:   2015-03-16 (Mon, 16 Mar 2015)

  Changed paths:
    M hw/9pfs/virtio-9p-local.c

  Log Message:
  -----------
  virtio: Fix memory leaks reported by Coverity

All four leaks are similar, so fix them in one patch.
Success path was not doing memory free.

Signed-off-by: Stefan Weil <address@hidden>
Signed-off-by: Aneesh Kumar K.V <address@hidden>


  Commit: 307146cb9359ad6d4544e00af073088772d165eb
      
https://github.com/qemu/qemu/commit/307146cb9359ad6d4544e00af073088772d165eb
  Author: Peter Maydell <address@hidden>
  Date:   2015-03-16 (Mon, 16 Mar 2015)

  Changed paths:
    M fsdev/virtfs-proxy-helper.c
    M hw/9pfs/virtio-9p-local.c
    M hw/9pfs/virtio-9p-posix-acl.c
    M hw/9pfs/virtio-9p-proxy.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/kvaneesh/for-upstream' into staging

* remotes/kvaneesh/for-upstream:
  virtio: Fix memory leaks reported by Coverity
  virtfs-proxy: Fix possible overflow
  fsdev/virtfs-proxy-helper: Fix improper use of negative value
  hw/9pfs/virtio-9p-posix-acl: Fix out-of-bounds access
  9pfs-proxy: tiny cleanups in proxy_pwritev and proxy_preadv
  9pfs-local: simplify/optimize local_mapped_attr_path()

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/2dfe7d07e2f4...307146cb9359