[Qemu-commits] [qemu/qemu] 919e11: gtk: use qemu_chr_alloc() to allocate CharDriverSt...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 919e11f3735c524e23d049512d3306ea1cc63fba
      
https://github.com/qemu/qemu/commit/919e11f3735c524e23d049512d3306ea1cc63fba
  Author: Daniel P. Berrange <address@hidden>
  Date:   2016-02-02 (Tue, 02 Feb 2016)

  Changed paths:
    M ui/gtk.c

  Log Message:
  -----------
  gtk: use qemu_chr_alloc() to allocate CharDriverState

The gd_vc_handler() callback is using g_malloc0() to
allocate the CharDriverState struct. As a result the
logfd field is getting initialized to 0, instead of
-1 when no logfile is requested.

The result is that when running

 $ qemu-system-i386 -nodefaults -chardev vc,id=mon0 -mon chardev=mon0

qemu duplicates all monitor output to stdout as well
as the GTK window.

Not using qemu_chr_alloc() was already a bug, but harmless
until this commit

  commit d0d7708ba29cbcc343364a46bff981e0ff88366f
  Author: Daniel P. Berrange <address@hidden>
  Date:   Mon Jan 11 12:44:41 2016 +0000

    qemu-char: add logfile facility to all chardev backends

which exposed the problem as a behaviour regression

Reported-by: Hervé Poussineau <address@hidden>
Signed-off-by: Daniel P. Berrange <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Tested-by: Hervé Poussineau <address@hidden>
Message-id: address@hidden
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: 56bdd4b69aa10bec274b1e812685bcf44dcb0c72
      
https://github.com/qemu/qemu/commit/56bdd4b69aa10bec274b1e812685bcf44dcb0c72
  Author: Jindřich Makovička <address@hidden>
  Date:   2016-02-02 (Tue, 02 Feb 2016)

  Changed paths:
    M include/ui/sdl2.h
    M ui/sdl.c
    M ui/sdl2.c

  Log Message:
  -----------
  sdl: shorten the GUI refresh interval when mouse or keyboard is active

Signed-off-by: Jindřich Makovička <address@hidden>
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: baa3f63827877c3632a3f7570eb772f3da4658bd
      
https://github.com/qemu/qemu/commit/baa3f63827877c3632a3f7570eb772f3da4658bd
  Author: Peter Maydell <address@hidden>
  Date:   2016-02-02 (Tue, 02 Feb 2016)

  Changed paths:
    M include/ui/sdl2.h
    M ui/gtk.c
    M ui/sdl.c
    M ui/sdl2.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/kraxel/tags/pull-ui-20160202-1' into 
staging

ui: gtk vc fix, adaptive sdl refresh.

# gpg: Signature made Tue 02 Feb 2016 13:06:07 GMT using RSA key ID D3E87138
# gpg: Good signature from "Gerd Hoffmann (work) <address@hidden>"
# gpg:                 aka "Gerd Hoffmann <address@hidden>"
# gpg:                 aka "Gerd Hoffmann (private) <address@hidden>"

* remotes/kraxel/tags/pull-ui-20160202-1:
  sdl: shorten the GUI refresh interval when mouse or keyboard is active
  gtk: use qemu_chr_alloc() to allocate CharDriverState

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/958e36936079...baa3f6382787