[Qemu-commits] [qemu/qemu] 4d3fc4: vfio/pci: Fix VGA quirks

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 4d3fc4fdc6857e33346ed58ae55870f59391ee71
      
https://github.com/qemu/qemu/commit/4d3fc4fdc6857e33346ed58ae55870f59391ee71
  Author: Alex Williamson <address@hidden>
  Date:   2016-06-30 (Thu, 30 Jun 2016)

  Changed paths:
    M hw/vfio/pci-quirks.c
    M hw/vfio/pci.h

  Log Message:
  -----------
  vfio/pci: Fix VGA quirks

Commit 2d82f8a3cdb2 ("vfio/pci: Convert all MemoryRegion to dynamic
alloc and consistent functions") converted VFIOPCIDevice.vga to be
dynamically allocted, negating the need for VFIOPCIDevice.has_vga.
Unfortunately not all of the has_vga users were converted, nor was
the field removed from the structure.  Correct these oversights.

Reported-by: Peter Maloney <address@hidden>
Tested-by: Peter Maloney <address@hidden>
Fixes: 2d82f8a3cdb2 ("vfio/pci: Convert all MemoryRegion to dynamic alloc and 
consistent functions")
Fixes: https://bugs.launchpad.net/qemu/+bug/1591628
Cc: address@hidden
Signed-off-by: Alex Williamson <address@hidden>


  Commit: 325ae8d548ebeee99cbebd38e2ff0909a9081c50
      
https://github.com/qemu/qemu/commit/325ae8d548ebeee99cbebd38e2ff0909a9081c50
  Author: Chen Fan <address@hidden>
  Date:   2016-06-30 (Thu, 30 Jun 2016)

  Changed paths:
    M hw/vfio/pci.c

  Log Message:
  -----------
  vfio: add pcie extended capability support

For vfio pcie device, we could expose the extended capability on
PCIE bus. due to add a new pcie capability at the tail of the chain,
in order to avoid config space overwritten, we introduce a copy config
for parsing extended caps. and rebuild the pcie extended config space.

Signed-off-by: Chen Fan <address@hidden>
Tested-by: Laszlo Ersek <address@hidden>
Signed-off-by: Alex Williamson <address@hidden>


  Commit: e37dac06dc4e85a2f46c24261c0dfdf2a30b50e3
      
https://github.com/qemu/qemu/commit/e37dac06dc4e85a2f46c24261c0dfdf2a30b50e3
  Author: Alex Williamson <address@hidden>
  Date:   2016-06-30 (Thu, 30 Jun 2016)

  Changed paths:
    M hw/vfio/pci.c
    M hw/vfio/trace-events

  Log Message:
  -----------
  vfio/pci: Hide SR-IOV capability

The kernel currently exposes the SR-IOV capability as read-only
through vfio-pci.  This is sufficient to protect the host kernel, but
has the potential to confuse guests without further virtualization.
In particular, OVMF tries to size the VF BARs and comes up with absurd
results, ending with an assert.  There's not much point in adding
virtualization to a read-only capability, so we simply hide it for
now.  If the kernel ever enables SR-IOV virtualization, we should
easily be able to test it through VF BAR sizing or explicit flags.

Testing whether we should parse extended capabilities is also pulled
into the function to keep these assumptions in one place.

Tested-by: Laszlo Ersek <address@hidden>
Signed-off-by: Alex Williamson <address@hidden>


  Commit: d22d8956b185c002b50a4d0883aff61f857347ef
      
https://github.com/qemu/qemu/commit/d22d8956b185c002b50a4d0883aff61f857347ef
  Author: Alexey Kardashevskiy <address@hidden>
  Date:   2016-06-30 (Thu, 30 Jun 2016)

  Changed paths:
    M hw/vfio/common.c
    M include/exec/memory.h
    M memory.c

  Log Message:
  -----------
  memory: Add MemoryRegionIOMMUOps.notify_started/stopped callbacks

The IOMMU driver may change behavior depending on whether a notifier
client is present.  In the case of POWER, this represents a change in
the visibility of the IOTLB, for other drivers such as intel-iommu and
future AMD-Vi emulation, notifier support is not yet enabled and this
provides the opportunity to flag that incompatibility.

Signed-off-by: Alexey Kardashevskiy <address@hidden>
Reviewed-by: David Gibson <address@hidden>
Reviewed-by: Peter Xu <address@hidden>
Tested-by: Peter Xu <address@hidden>
Acked-by: Paolo Bonzini <address@hidden>
[new log & extracted from [PATCH qemu v17 12/12] spapr_iommu, vfio, memory: 
Notify IOMMU about starting/stopping listening]
Signed-off-by: Alex Williamson <address@hidden>


  Commit: 3cb3b1549f5401dc3a5e1d073e34063dc274136f
      
https://github.com/qemu/qemu/commit/3cb3b1549f5401dc3a5e1d073e34063dc274136f
  Author: Alex Williamson <address@hidden>
  Date:   2016-06-30 (Thu, 30 Jun 2016)

  Changed paths:
    M hw/i386/intel_iommu.c

  Log Message:
  -----------
  intel_iommu: Throw hw_error on notify_started

We don't currently support the MemoryRegionIOMMUOps notifier, so throw
an error should a device require it.

Reviewed-by: Marcel Apfelbaum <address@hidden>
Reviewed-by: David Gibson <address@hidden>
Reviewed-by: Peter Xu <address@hidden>
Tested-by: Peter Xu <address@hidden>
Acked-by: Paolo Bonzini <address@hidden>
Signed-off-by: Alex Williamson <address@hidden>


  Commit: 94e31093ff34ead50dc3970699a4e36582fb3f17
      
https://github.com/qemu/qemu/commit/94e31093ff34ead50dc3970699a4e36582fb3f17
  Author: Peter Maydell <address@hidden>
  Date:   2016-07-01 (Fri, 01 Jul 2016)

  Changed paths:
    M hw/i386/intel_iommu.c
    M hw/vfio/common.c
    M hw/vfio/pci-quirks.c
    M hw/vfio/pci.c
    M hw/vfio/pci.h
    M hw/vfio/trace-events
    M include/exec/memory.h
    M memory.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/awilliam/tags/vfio-update-20160630.0' 
into staging

VFIO updates 2016-06-30

 - Fix VGA quirks (stable 2.6) (Alex Williamson)
 - Registering PCIe extended capabilities (Chen Fan)
 - Hide read-only SR-IOV capability from VM (Alex Williamson)
 - MemoryRegionIOMMUOps.notify_started/stopped (Alexey Kardashevskiy)
 - hw_error on intel_iommu notify_started  (Alex Williamson)

# gpg: Signature made Thu 30 Jun 2016 20:45:55 BST
# gpg:                using RSA key 0x239B9B6E3BB08B22
# gpg: Good signature from "Alex Williamson <address@hidden>"
# gpg:                 aka "Alex Williamson <address@hidden>"
# gpg:                 aka "Alex Williamson <address@hidden>"
# gpg:                 aka "Alex Williamson <address@hidden>"
# Primary key fingerprint: 42F6 C04E 540B D1A9 9E7B  8A90 239B 9B6E 3BB0 8B22

* remotes/awilliam/tags/vfio-update-20160630.0:
  intel_iommu: Throw hw_error on notify_started
  memory: Add MemoryRegionIOMMUOps.notify_started/stopped callbacks
  vfio/pci: Hide SR-IOV capability
  vfio: add pcie extended capability support
  vfio/pci: Fix VGA quirks

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/1fb4c13e4f92...94e31093ff34