[Qemu-commits] [qemu/qemu] fe3101: build-sys: link tests/data

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: fe31017f79e591463599de30b11b24835f10f18b
      
https://github.com/qemu/qemu/commit/fe31017f79e591463599de30b11b24835f10f18b
  Author: Marc-André Lureau <address@hidden>
  Date:   2016-07-25 (Mon, 25 Jul 2016)

  Changed paths:
    M configure

  Log Message:
  -----------
  build-sys: link tests/data

Link a common tests data directory to the build directory.

Signed-off-by: Marc-André Lureau <address@hidden>
Signed-off-by: Michael Roth <address@hidden>


  Commit: 1741b945f245dd51018fb31748d302eda1ddaafd
      
https://github.com/qemu/qemu/commit/1741b945f245dd51018fb31748d302eda1ddaafd
  Author: Marc-André Lureau <address@hidden>
  Date:   2016-07-25 (Mon, 25 Jul 2016)

  Changed paths:
    A tests/data/test-qga-config
    M tests/test-qga.c

  Log Message:
  -----------
  tests: use static qga config file

Do not create a leaking temporary file, but use a static file instead.

Signed-off-by: Marc-André Lureau <address@hidden>
Reported-by: Peter Maydell <address@hidden>
Signed-off-by: Michael Roth <address@hidden>


  Commit: 690604f696db6b3da35988e29da3f8d7966e12bc
      
https://github.com/qemu/qemu/commit/690604f696db6b3da35988e29da3f8d7966e12bc
  Author: Michael Roth <address@hidden>
  Date:   2016-07-25 (Mon, 25 Jul 2016)

  Changed paths:
    M configure

  Log Message:
  -----------
  configure: mark qemu-ga VSS includes as system headers

As of e4650c81, we do w32 builds with -Werror enabled. Unfortunately
for cases where we enable VSS support in qemu-ga, we still have
warnings generated by VSS includes that ship as part of the Microsoft
VSS SDK.

We can selectively address a number of these warnings using

  #pragma GCC diagnostic ignored ...

but at least one of these:

  warning: ‘typedef’ was ignored in this declaration

resulting from declarations of the form:

  typedef struct Blah { ... };

does not provide a specific command-line/pragma option to disable
warnings of the sort.

To allow VSS builds to succeed, the next-best option is disabling
these warnings on a per-file basis. pragmas like #pragma GCC
system_header can be used to declare subsequent includes/declarations
as being exempt from normal warnings, but this must be done within
a header file.

Since we don't control the VSS SDK, we'd need to rely on a
intermediate header include to accomplish this, and
since different objects in the VSS link target rely on different
headers from the VSS SDK, this would become somewhat of a rat's nest
(though not totally unmanageable).

The next step up in granularity is just marking the entire VSS
SDK include path as system headers via -isystem. This is a bit more
heavy-handed, but since this SDK hasn't changed since 2005, there's
likely little to be gained from selectively disabling warnings
anyway, so we implement that approach here.

This fixes the -Werror failures in both the configure test and the
qga build due to shared reliance on $vss_win32_include. For the
same reason, this also enforces a new dependency on -isystem support
in the C/C++ compiler when building QGA with VSS enabled.

Cc: Thomas Huth <address@hidden>
Cc: Stefan Weil <address@hidden>
Cc: Paolo Bonzini <address@hidden>
Reviewed-by: Thomas Huth <address@hidden>
Signed-off-by: Michael Roth <address@hidden>


  Commit: a467bb9940145ed678ac6f84e9cc260f31174905
      
https://github.com/qemu/qemu/commit/a467bb9940145ed678ac6f84e9cc260f31174905
  Author: Peter Maydell <address@hidden>
  Date:   2016-07-26 (Tue, 26 Jul 2016)

  Changed paths:
    M configure
    A tests/data/test-qga-config
    M tests/test-qga.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/mdroth/tags/qga-pull-2016-07-25-tag' 
into staging

qemu-ga patch queue for 2.7

* fix w32 build failures due to -Werror when building with VSS/fsfreeze
  enabled
* fix leaking for qemu-ga config files in `make check`

# gpg: Signature made Mon 25 Jul 2016 20:01:09 BST
# gpg:                using RSA key 0x3353C9CEF108B584
# gpg: Good signature from "Michael Roth <address@hidden>"
# gpg:                 aka "Michael Roth <address@hidden>"
# gpg:                 aka "Michael Roth <address@hidden>"
# Primary key fingerprint: CEAC C9E1 5534 EBAB B82D  3FA0 3353 C9CE F108 B584

* remotes/mdroth/tags/qga-pull-2016-07-25-tag:
  configure: mark qemu-ga VSS includes as system headers
  tests: use static qga config file
  build-sys: link tests/data

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/2d2e632ad00d...a467bb994014